Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: simplify kube-controller-manager patches #20954

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Sep 12, 2018

Cherry pick of #20925 to release-3.11

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602793

We are still keeping RBAC policies and service accounts installed.
This is just to avoid duplicating that work in ansible for now.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602793
@gnufied gnufied requested a review from deads2k September 12, 2018 14:03
@gnufied
Copy link
Member Author

gnufied commented Sep 12, 2018

/assign @deads2k

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2018
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2018
@openshift-merge-robot openshift-merge-robot merged commit f54abfd into openshift:release-3.11 Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants