Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.11] Router metrics change to use http1 cockroach db matcher #21043

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #20873

/assign ironcladlou

@ironcladlou
Copy link
Contributor

/cc @nhr @knobunc

@nhr
Copy link
Member

nhr commented Sep 19, 2018

Make it so

@knobunc
Copy link
Contributor

knobunc commented Sep 19, 2018

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2018
@knobunc
Copy link
Contributor

knobunc commented Sep 19, 2018

/retest

1 similar comment
@knobunc
Copy link
Contributor

knobunc commented Sep 19, 2018

/retest

@knobunc knobunc merged commit 36b3fc2 into openshift:release-3.11 Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants