Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31868: Add debug logging for SLB monitortest cleanup #28697

Merged

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Apr 9, 2024

This test is failing periodically in some cases and we can't see when
the problem is occurring to correlate with logs or intervals because the
framework doesn't log much of anything.

This test is failing periodically in some cases and we can't see when
the problem is occurring to correlate with logs or intervals because the
framework doesn't log much of anything.
@dgoodwin dgoodwin changed the title Add debug logging for SLB monitortest cleanup OCPBUGS-31868: Add debug logging for SLB monitortest cleanup Apr 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2024
@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-31868, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This test is failing periodically in some cases and we can't see when
the problem is occurring to correlate with logs or intervals because the
framework doesn't log much of anything.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 9, 2024
@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning April 9, 2024 12:10
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@neisw
Copy link
Contributor

neisw commented Apr 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@DennisPeriquet
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2024
@openshift-ci-robot
Copy link

@DennisPeriquet: This pull request references Jira Issue OCPBUGS-31868, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef0a1a0 and 2 for PR HEAD 79ea7f5 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a42236a and 1 for PR HEAD 79ea7f5 in total

@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 79ea7f5 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn 79ea7f5 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node 79ea7f5 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial 79ea7f5 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 79ea7f5

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (98) are below the historical average (935): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-merge-bot openshift-merge-bot bot merged commit 3d444ed into openshift:master Apr 10, 2024
18 of 22 checks passed
@openshift-ci-robot
Copy link

@dgoodwin: Jira Issue OCPBUGS-31868: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31868 has been moved to the MODIFIED state.

In response to this:

This test is failing periodically in some cases and we can't see when
the problem is occurring to correlate with logs or intervals because the
framework doesn't log much of anything.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202404101645.p0.g3d444ed.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-04-13-070448

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-05-04-214435

@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/cherry-pick release-4.14

@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@prb112: #28697 failed to apply on top of branch "release-4.14":

Applying: Add debug logging for SLB monitortest cleanup
Using index info to reconstruct a base tree...
M	pkg/monitortestframework/impl.go
M	pkg/monitortestframework/panic.go
M	pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
CONFLICT (content): Merge conflict in pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
Auto-merging pkg/monitortestframework/panic.go
CONFLICT (content): Merge conflict in pkg/monitortestframework/panic.go
Auto-merging pkg/monitortestframework/impl.go
CONFLICT (content): Merge conflict in pkg/monitortestframework/impl.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add debug logging for SLB monitortest cleanup
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@prb112: #28697 failed to apply on top of branch "release-4.15":

Applying: Add debug logging for SLB monitortest cleanup
Using index info to reconstruct a base tree...
M	pkg/monitortestframework/impl.go
M	pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
CONFLICT (content): Merge conflict in pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
Auto-merging pkg/monitortestframework/impl.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add debug logging for SLB monitortest cleanup
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants