-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added readiness check to LDAP server pod #5064
added readiness check to LDAP server pod #5064
Conversation
I have a feeling this is due to me not understanding |
af75ee7
to
af37153
Compare
}, | ||
"readinessProbe": { | ||
"exec": { | ||
"command": ["bash", "-c", "\"ldapsearch -x -b dc=example,dc=com | grep organization\""] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprised the quoting on the third arg is needed... is it not treated as a single arg to bash?
Status of this? |
@smarterclayton In-flight. I'll have bandwidth for this once |
Just asking as I was going through the older PRs On Oct 29, 2015, at 8:12 AM, Steve Kuznetsov notifications@github.com @smarterclayton https://github.com/smarterclayton In-flight. I'll have — |
af37153
to
ef8530f
Compare
Will this be checked by the extended test? If so, run it and I'll merge on a pass. |
98d7c9c
to
b486b06
Compare
@deads2k it should be checked, yes [testonlyextended:ldap_groups] |
I guess that syntax doesn't work. OK. [test][extended:ldap_groups] |
@stevekuznetsov hey - don't want to put the precise string (cause it will kick a build off), but it is "testonlyextended" in between '[' and ']', followed by another '[' ']' pairing, with "core" and then the focus you want (i.e. ldap in this case I would imagine) in between parens. If that doesn't make sense, just ping me in IRC. |
b486b06
to
fc4e3ab
Compare
Very unclear how |
fc4e3ab
to
d1480b5
Compare
flake on
#6173 |
d1480b5
to
498a668
Compare
498a668
to
5dd76bf
Compare
Evaluated for origin test up to 5dd76bf |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8088/) (Extended Tests: ldap_groups) |
LGTM, [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4474/) (Image: devenv-rhel7_3031) |
Evaluated for origin merge up to 5dd76bf |
Merged by openshift-bot
Implemented an
exec
readiness probe, with the following check:$ bash -c "ldapsearch -x -b dc=example,dc=com | grep organization"
This should catch the
organization
in thedc=example,dc=com
as well as all of theorganizationalUnit
entries we have. This currently never returns atrue
... cc @liggitt @deads2k thoughts appreciated