added readiness check to LDAP server pod

[stevekuznetsov]

Implemented an exec readiness probe, with the following check:

$ bash -c "ldapsearch -x -b dc=example,dc=com | grep organization"

This should catch the organization in the dc=example,dc=com as well as all of the organizationalUnit entries we have. This currently never returns a true ... cc @liggitt @deads2k thoughts appreciated

[stevekuznetsov]

I have a feeling this is due to me not understanding exec fully ... but let's be honest that man page was terrifying to look at and I came out dumber than I went in

[stevekuznetsov]

@liggitt @deads2k PTAL

[liggitt]

surprised the quoting on the third arg is needed... is it not treated as a single arg to bash?

[smarterclayton]

Status of this?

[stevekuznetsov]

@smarterclayton In-flight. I'll have bandwidth for this once prune-groups is finished. Until then we have a sleep in the test suite ... is that long wait what you're not liking at the moment?

[smarterclayton]

Just asking as I was going through the older PRs

On Oct 29, 2015, at 8:12 AM, Steve Kuznetsov notifications@github.com
wrote:

@smarterclayton https://github.com/smarterclayton In-flight. I'll have
bandwidth for this once prune-groups is finished. Until then we have a sleep
in the test suite ... is that long wait what you're not liking at the
moment?

—
Reply to this email directly or view it on GitHub
#5064 (comment).

[stevekuznetsov]

The check now runs ldapsearch -x -b dc=example,dc=com and will fail if nothing has been initialized with error 32, succeed once server is ready. @deads2k @liggitt PTAL

[deads2k]

Will this be checked by the extended test? If so, run it and I'll merge on a pass.

[stevekuznetsov]

@deads2k it should be checked, yes

[testonlyextended:ldap_groups]

[stevekuznetsov]

I guess that syntax doesn't work. OK.
@gabemontero I've seen you use similar before, how do I tell Jenkins to just run one extended suite?

[test][extended:ldap_groups]

[gabemontero]

@stevekuznetsov hey - don't want to put the precise string (cause it will kick a build off), but it is "testonlyextended" in between '[' and ']', followed by another '[' ']' pairing, with "core" and then the focus you want (i.e. ldap in this case I would imagine) in between parens.

If that doesn't make sense, just ping me in IRC.

[stevekuznetsov]

Very unclear how valid_all_ldap_sync_delete_prune file got written as a .txt, when #6323 merged with a green extended run... I distinctly remember fixing this problem in that pull.

[stevekuznetsov]

flake on TestAuthorizationRestrictedAccessForProjectAdmins here:

E1222 02:32:20.109854   20090 create_dockercfg_secrets.go:109] secrets "builder-token-9onls" already exists
--- FAIL: TestAuthorizationRestrictedAccessForProjectAdmins-4 (12.84s)
    authorization_test.go:45: unexpected error: namespaces "hammer-project" already exists

#6173
re[test]

[openshift-bot]

Evaluated for origin test up to 5dd76bf

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8088/) (Extended Tests: ldap_groups)

[stevekuznetsov]

@deads2k @liggitt got green

[liggitt]

LGTM, [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4474/) (Image: devenv-rhel7_3031)

[openshift-bot]

Evaluated for origin merge up to 5dd76bf