unified printing strategy #5334

stevekuznetsov · 2015-10-22T16:46:50Z

Fixes #5332
Fixes #5256

Updates the following commands to use cmdutil.PrintSuccess:

openshift admin new-project
openshift admin groups new
openshift cli new-project (TODO)
openshift cli start-build
openshift cli secrets new
openshift cli secrets new-dockercfg
openshift cli secrets new-basicauth
openshift cli secrets new-sshauth
openshift ex sync-groups

@deads2k

stevekuznetsov · 2015-10-22T16:46:59Z

[test] me

deads2k · 2015-10-22T17:44:31Z

pkg/cmd/admin/groups/new.go

 		},
 	}

+	kcmdutil.AddOutputFlagsForMutation(cmd)


refactor this method upstream to bind to a variable.

@deads2k what benefits from that change do I use to justify that PR?

@deads2k what benefits from that change do I use to justify that PR?

Currently, the printer and output methods on the Factory are very difficult to use during delegation flows. They rely on having a cmd set up with exactly the "right" flags. We should refactor the Factory to specify the actual values they need.

Having the proper object bound in will allow you separate the data from its expression.

@deads2k thanks

smarterclayton · 2015-10-24T04:38:11Z

pkg/cmd/cli/cmd/startbuild.go

@@ -78,6 +78,9 @@ func NewCmdStartBuild(fullName string, f *clientcmd.Factory, out io.Writer) *cob

 	cmd.Flags().String("git-post-receive", "", "The contents of the post-receive hook to trigger a build")
 	cmd.Flags().String("git-repository", "", "The path to the git repository for post-receive; defaults to the current directory")
+
+	cmdutil.AddOutputFlagsForMutation(cmd)


Omit start build from this pr because this breaks a lot of examples and tests that expect the output to be the name only. We'll need a more nuanced solution there.

stevekuznetsov · 2016-01-06T16:30:29Z

@deads2k I haven't made upstream changes to AddOutputFlagsForMutation yet, but I've updated the rest of this pull. Ready for another look.

stevekuznetsov · 2016-01-06T17:06:56Z

[test]
[extended:ldap_groups]

deads2k · 2016-01-09T01:19:46Z

re[test]

deads2k · 2016-01-11T13:49:55Z

legit failure this time.

stevekuznetsov · 2016-01-20T15:48:08Z

Jenkins cache cleared, re[test]

stevekuznetsov · 2016-01-21T13:22:51Z

@danmcp the bot comment here claims the test succeeded, but both jobs failed. Why?

stevekuznetsov · 2016-01-21T13:25:46Z

imagestream flake here:

FAILURE after 59.313s: hack/../test/cmd/builds.sh:76: executing 'oc get is ruby-22-centos7' expecting any result and text 'latest'; re-trying every 0.2s until completion or 60.000s: the command timed out
Standard output from the command:
NAME              DOCKER REPO              TAGS      UPDATED
ruby-22-centos7   centos/ruby-22-centos7
... repeated 146 times
There was no error output from the command.

#6259

danmcp · 2016-01-21T13:42:57Z

@stevekuznetsov It's almost certainly because @deads2k and myself had killed a few jobs by hand yesterday and didn't clean everything up fully. This was the one that passed:

https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/224/

stevekuznetsov · 2016-01-26T15:32:16Z

re[test]

stevekuznetsov · 2016-01-27T13:55:47Z

flake on test/cmd/builds here:

Running hack/../test/cmd/builds.sh:68: executing 'oc new-build -D "FROM centos:7" -o json | python -m json.tool' expecting success...
FAILURE after 30.228s: hack/../test/cmd/builds.sh:68: executing 'oc new-build -D "FROM centos:7" -o json | python -m json.tool' expecting success: the command returned the wrong error code
There was no output from the command.
Standard error from the command:
error: only a partial match was found for "centos:7": "cmd-builds/centos"
No JSON object could be decoded

#6818

stevekuznetsov · 2016-01-27T13:59:44Z

I honestly can't tell what caused the failure in this log.

re[test], @deads2k barring a real fail I think this is ready

fabianofranz · 2016-02-12T14:24:13Z

UP, @stevekuznetsov please rebase and let's try to get this in.

stevekuznetsov · 2016-02-24T15:51:57Z

@fabianofranz this is broken, blocked on factory.ClientMapperForCommand not existing anymore (???) -- do you have the bandwidth to take this over?

openshift-bot · 2016-02-24T15:55:31Z

Evaluated for origin test up to 65558ac

openshift-bot · 2016-02-24T16:15:35Z

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1578/) (Extended Tests: ldap_groups)

openshift-bot · 2016-04-02T16:15:10Z

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

stevekuznetsov · 2016-05-25T21:47:22Z

Closing this as I don't think it's really relevant anymore ... @fabianofranz feel free to pick this up if it is

stevekuznetsov force-pushed the skuznets/print-success branch from 386183d to b2a4b16 Compare October 22, 2015 16:47

deads2k reviewed Oct 22, 2015
View reviewed changes

openshift-bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 22, 2015

smarterclayton reviewed Oct 24, 2015
View reviewed changes

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2015

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 14, 2015

stevekuznetsov force-pushed the skuznets/print-success branch 8 times, most recently from 2b17e27 to 4daf41d Compare January 6, 2016 16:28

stevekuznetsov force-pushed the skuznets/print-success branch from 4daf41d to 24df569 Compare January 6, 2016 16:42

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2016

stevekuznetsov force-pushed the skuznets/print-success branch 3 times, most recently from 1f70f77 to a0d1048 Compare January 6, 2016 20:58

deads2k self-assigned this Jan 8, 2016

stevekuznetsov force-pushed the skuznets/print-success branch from a0d1048 to 4ce7574 Compare January 9, 2016 04:09

stevekuznetsov force-pushed the skuznets/print-success branch from 4ce7574 to b293b60 Compare January 20, 2016 20:43

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2016

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 22, 2016

unified printing strategy

65558ac

stevekuznetsov force-pushed the skuznets/print-success branch from b293b60 to 65558ac Compare February 24, 2016 15:50

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2016

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2016

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 21, 2016

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 28, 2016

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 5, 2016

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 23, 2016

stevekuznetsov closed this May 25, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unified printing strategy #5334

unified printing strategy #5334

stevekuznetsov commented Oct 22, 2015

stevekuznetsov commented Oct 22, 2015

deads2k Oct 22, 2015

stevekuznetsov Jan 4, 2016

deads2k Jan 4, 2016

stevekuznetsov Jan 4, 2016

smarterclayton Oct 24, 2015

stevekuznetsov commented Jan 6, 2016

stevekuznetsov commented Jan 6, 2016

deads2k commented Jan 9, 2016

deads2k commented Jan 11, 2016

stevekuznetsov commented Jan 20, 2016

stevekuznetsov commented Jan 21, 2016

stevekuznetsov commented Jan 21, 2016

danmcp commented Jan 21, 2016

stevekuznetsov commented Jan 26, 2016

stevekuznetsov commented Jan 27, 2016

stevekuznetsov commented Jan 27, 2016

fabianofranz commented Feb 12, 2016

stevekuznetsov commented Feb 24, 2016

openshift-bot commented Feb 24, 2016

openshift-bot commented Feb 24, 2016

openshift-bot commented Apr 2, 2016

stevekuznetsov commented May 25, 2016

unified printing strategy #5334

unified printing strategy #5334

Conversation

stevekuznetsov commented Oct 22, 2015

stevekuznetsov commented Oct 22, 2015

deads2k Oct 22, 2015

Choose a reason for hiding this comment

stevekuznetsov Jan 4, 2016

Choose a reason for hiding this comment

deads2k Jan 4, 2016

Choose a reason for hiding this comment

stevekuznetsov Jan 4, 2016

Choose a reason for hiding this comment

smarterclayton Oct 24, 2015

Choose a reason for hiding this comment

stevekuznetsov commented Jan 6, 2016

stevekuznetsov commented Jan 6, 2016

deads2k commented Jan 9, 2016

deads2k commented Jan 11, 2016

stevekuznetsov commented Jan 20, 2016

stevekuznetsov commented Jan 21, 2016

stevekuznetsov commented Jan 21, 2016

danmcp commented Jan 21, 2016

stevekuznetsov commented Jan 26, 2016

stevekuznetsov commented Jan 27, 2016

stevekuznetsov commented Jan 27, 2016

fabianofranz commented Feb 12, 2016

stevekuznetsov commented Feb 24, 2016

openshift-bot commented Feb 24, 2016

openshift-bot commented Feb 24, 2016

openshift-bot commented Apr 2, 2016

stevekuznetsov commented May 25, 2016