-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new deployment scale endpoint to request a scale event #5852
Use new deployment scale endpoint to request a scale event #5852
Conversation
[test] |
@ironcladlou note that by making this switch, we allow deployments (rcs) to be scaled only when they are complete due to
|
@Kargakis @ironcladlou I would expect to be able to adjust the target scale regardless of whether a deployment was in progress |
Say you have
And in the middle of the deployment process you try to
Note that this happens now. I don't see why would |
Use the new deploymentconfigs/{name}/scale endpooint instead of trying to resolve the latest deployment for a config in the client.
Evaluated for origin test up to 55f7b3b |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7070/) |
You can't safely adjust the scale of an in progress deployment due without a fix for #5597. |
Agree, but it sounded like @Kargakis was arguing that you shouldn't be allowed to adjust dc scale while a deployment was in progress, even once we resolve race and controller contention issues. I think you should. |
I agree with @liggitt You should be able to adjust the scale even if the On Thu, Nov 12, 2015 at 9:38 AM, Jordan Liggitt notifications@github.com
|
To clarify: yes, you should be able to scale regardless of whether a deployment is in-progress. The only reason there is any code to restrict that is to work around #5597. |
As long as there is a single point that actually scales the deployment (what #5597 is going to do), I'm fine with scaling whenever you want. |
This PR has been rolled into #5875 |
:katamari'd: |
Use the new deploymentconfigs/{name}/scale endpooint instead of trying to resolve the latest deployment for a config in the client.
Btw I would love if I could poll the scale subresource (GET dc/%s/scale instead of polling the latest rc) in case of a specified --timeout (which means wait until all pods are up) but getting the scale of a dc isn't returning the current replicas of the latest.
@ironcladlou @DirectXMan12