-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show 'none' when there is no builder image #6366
Show 'none' when there is no builder image #6366
Conversation
@jwforres PTAL |
May want to use directive |
Does this only occur with empty values? Does adding |
@spadgett how will that behave in the absence of a value? |
|
Another possible fix is to use |
181685d
to
bbe813e
Compare
|
Sorry, I wasn't clear. It's a directive, not a class. So you'd need to use it this way:
|
Why 40? |
I'm not sure 40 is the value we want, just an example. |
WDYT about showing default value instead of empty string? Like |
Talked on IRC with @spadgett and @php-coder and we decided on showing none as we have in multiple other places in the Web Console. |
Using 'truncate' when the tag is empty causes the next <dd> contents to be shifted up, and the labels will point to the wrong piece of information. Furthermore, we already show 'none' in multiple other places in the Web Console in similar contexts.
bbe813e
to
7259c16
Compare
@spadgett PTAL |
@jwforres PTAL |
I would rather use custom filter for that instead of copy&paste |
Grepping |
Not sure if we can have the
|
agree with @rhcarvalho not the PR for a refactor, this is fine [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4399/) (Image: devenv-rhel7_2984) |
Evaluated for origin merge up to 7259c16 |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 7259c16 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7928/) |
Jenkins test failure was a flake: #6381 |
Merged by openshift-bot
Using 'truncate' when the tag is empty causes the next
<dd>
contents to be shifted up, and the labels will point to the wrong piece of information.Furthermore, we already show 'none' in multiple other places in the Web Console in similar contexts.
Fixes #6364.