Show 'none' when there is no builder image

[rhcarvalho]

Using 'truncate' when the tag is empty causes the next <dd> contents to be shifted up, and the labels will point to the wrong piece of information.
Furthermore, we already show 'none' in multiple other places in the Web Console in similar contexts.

Fixes #6364.

[rhcarvalho]

@jwforres PTAL

[spadgett]

May want to use directive truncate-long-text instead if we're worried about long values.

[spadgett]

Does this only occur with empty values? Does adding   in place of the empty value fix it?

[rhcarvalho]

@spadgett how will that behave in the absence of a value?

[spadgett]

how will that behave in the absence of a value?

truncate-long-text? It should just be empty, but it doesn't use the problematic truncate class.

[spadgett]

Another possible fix is to use ng-class to only add truncate when there is content.

https://docs.angularjs.org/api/ng/directive/ngClass

[rhcarvalho]

truncate-long-text works and seems to be a better fix IMO. Updated the PR. Thanks @spadgett

[spadgett]

Sorry, I wasn't clear. It's a directive, not a class. So you'd need to use it this way:

<truncate-long-text content="(build | buildStrategy).from | imageObjectRef : build.metadata.namespace" limit="40"></truncate-long-text>

[rhcarvalho]

Actually truncate-long-text has a draw back...

Is splits the text into multiple lines, while truncate truncates and appends "..."

[rhcarvalho]

limit="40"

Why 40?

[spadgett]

truncate-long-text will truncate at whatever character limit you specify. truncate class will use the available space, so it might be better.

I'm not sure 40 is the value we want, just an example.

[php-coder]

WDYT about showing default value instead of empty string? Like Builder image: none. Or maybe even don't show this field at all (by using ng-if)?

[rhcarvalho]

Talked on IRC with @spadgett and @php-coder and we decided on showing none as we have in multiple other places in the Web Console.

[rhcarvalho]

@spadgett PTAL

[rhcarvalho]

@jwforres PTAL

[php-coder]

I would rather use custom filter for that instead of copy&paste <span><em>none<em></span>. The example of such filter could be found on StackOverflow: http://stackoverflow.com/questions/27490652/angular-default-value-if-binding-is-null

[rhcarvalho]

Grepping <em>none</em></span> finds 14 occurrences. That's a nice refactor, but not for me / this PR. I'd keep this focused on fixing the bug.

[spadgett]

Not sure if we can have the em markup in the none case using a default value filter. Often, we just say

{{ foo || "none" }}

[jwforres]

agree with @rhcarvalho not the PR for a refactor, this is fine [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4399/) (Image: devenv-rhel7_2984)

[openshift-bot]

Evaluated for origin merge up to 7259c16

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to 7259c16

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7928/)

[rhcarvalho]

Jenkins test failure was a flake: #6381