promoted group prune and sync from experimental #6369

stevekuznetsov · 2015-12-17T15:38:08Z

ref #6276

This PR promotes openshift ex {sync,prune}-groups to oadm groups {sync,prune}

@deads2k PTAL

stevekuznetsov · 2015-12-17T15:38:18Z

[test][extended:ldap_groups]

deads2k · 2015-12-17T15:55:11Z

Link to the doc updates please.

deads2k · 2015-12-17T16:00:02Z

Update your description to show where this moved to and from.

deads2k · 2015-12-17T16:00:49Z

Also, since we doc'ed it, maintain the location under openshift ex too. Not the go package, just the commands.

stevekuznetsov · 2015-12-17T16:06:02Z

@deads2k doc PR made, re-instated openshift ex {sync,prune}-groups

deads2k · 2015-12-17T16:25:32Z

Add test for all four flavors in test-cmd. Just a simple openshift ex sync-groups --help with a text check to make sure we're correctly plumbed through.

stevekuznetsov · 2015-12-17T16:26:43Z

Which bucket should I put that into? help? admin ?

deads2k · 2015-12-17T16:27:23Z

put it in help

stevekuznetsov · 2015-12-17T16:31:44Z

[test]

stevekuznetsov · 2015-12-18T14:10:09Z

again #6259...
[test][extended:ldap_groups]

stevekuznetsov · 2015-12-18T17:05:58Z

flake #6173 here

stevekuznetsov · 2015-12-18T17:06:07Z

re[test][extended:ldap_groups]

stevekuznetsov · 2015-12-18T18:44:16Z

@deads2k finally got green

deads2k · 2015-12-18T19:13:18Z

lgtm. @liggitt any complaint on the name?

0xmichalis · 2015-12-18T21:38:20Z

Shouldn't groups prune be a part of the existing prune command?

0xmichalis · 2015-12-18T21:40:08Z

Also are these two commands what 6276 is asking for?

stevekuznetsov · 2015-12-19T00:27:36Z

@soltysh #6276 touches this and also another pull AFAIK
oadm prune groups does seem more fitting, but I really don't like the user story for oadm prune groups and oadm groups sync...

stevekuznetsov · 2015-12-21T14:07:34Z

@deads2k should we put prune under oadm prune or oadm groups? Do we have a strategy doc for this?

deads2k · 2015-12-21T14:08:32Z

@deads2k should we put prune under oadm prune or oadm groups? Do we have a strategy doc for this?

You'll know it when you see it.

deads2k · 2015-12-21T14:13:12Z

@stevekuznetsov cross link prune to support all three calling locations. Add the new location to test-cmd/help

stevekuznetsov · 2015-12-21T14:26:35Z

@deads2k what should doc look like? oadm groups prune? oadm prune groups? Should we even mention the duality?

deads2k · 2015-12-21T14:27:34Z

@deads2k what should doc look like? oadm groups prune? oadm prune groups? Should we even mention the duality?

Let's keep congruence, so oadm groups prune. Don't bother mentioning aliases.

stevekuznetsov · 2015-12-21T17:53:15Z

@deads2k rebased, re[test][extended:ldap_groups]

stevekuznetsov · 2015-12-21T18:00:25Z

@deads2k Added help-text fixes (addition of --confirm to examples, fixed --type instead of --existing) but no renames to sync.go. PTAL

deads2k · 2015-12-21T18:05:50Z

@deads2k Added help-text fixes (addition of --confirm to examples, fixed --type instead of --existing) but no renames to sync.go. PTAL

I don't understand. Go back in your git reflog, find the changes and give me a second commit so I can jump to it.

deads2k · 2015-12-21T19:49:25Z

docs/generated/oadm_by_example_content.adoc

+  $ oadm groups sync --whitelist=/path/to/whitelist.txt --sync-config=/path/to/sync-config.yaml
+
+  # Sync all OpenShift Groups that have been synced previously with an LDAP server
+  $ oadm groups sync --existing --sync-config=/path/to/ldap-sync-config.yaml


need to regenerate

deads2k · 2015-12-21T19:49:57Z

I don't understand. Go back in your git reflog, find the changes and give me a second commit so I can jump to it.

I think I understand now. Get yourself back to green.

stevekuznetsov · 2015-12-21T19:58:56Z

updated docs & completions, re[test][extended:ldap_groups]

stevekuznetsov · 2015-12-22T00:33:18Z

e2e failing dc succeeded here:

deploymentconfig "failing-dc" created
++ Retrying until success or timeout: oc get rc/failing-dc-1

[FAIL] !!!!! Test Failed !!!!

may be #5680 ? output looks different

stevekuznetsov · 2015-12-22T00:33:29Z

re[test][extended:ldap_groups]

stevekuznetsov · 2015-12-22T06:50:53Z

flake on e2e pushing image here:

[INFO] Tagging and pushing ruby-22-centos7 to 172.30.83.160:5000/cache/ruby-22-centos7:latest
...
Error from server: User "e2e-user" cannot list all buildconfigs in the cluster

#6149

re[test][extended:ldap_groups]

stevekuznetsov · 2015-12-22T14:23:45Z

flake on e2e here:

Error from server: User "e2e-user" cannot list all buildconfigs in the cluster

#6149

liggitt · 2015-12-22T14:28:40Z

I think the real error is:

Error from server: 501: All the given peers are not reachable (failed to propose on members [https://172.18.7.165:4001] twice [last error: Unexpected HTTP status code]) [0]
!!! Error in hack/../test/end-to-end/core.sh:160
    'oc delete pod cli-with-token' exited with status 1
Call stack:
    1: hack/../test/end-to-end/core.sh:160 main(...)
Exiting with status 1

stevekuznetsov · 2015-12-22T14:42:13Z

@liggitt That seems more likely. Any opposition to me refactoring e2e to use os::cmd so we can read the output?

liggitt · 2015-12-22T15:54:37Z

Any opposition to me refactoring e2e to use os::cmd so we can read the output?

No strong opposition... I'd maybe start with just the ones capturing/echoing output to make the review easy, since that's the main issue that is making our lives difficult at the moment

stevekuznetsov · 2015-12-22T15:58:36Z

re[test][extended:ldap_groups]

stevekuznetsov · 2015-12-22T17:37:06Z

TestAuthorizationSubjectAccessReview flaked here:

I1222 11:46:52.522839   20535 etcd.go:37] Deleting &etcd.Node{Key:"/kubernetes.io", Value:"", Dir:true, Expiration:(*time.Time)(nil), TTL:0, Nodes:etcd.Nodes(nil), ModifiedIndex:0x33e, CreatedIndex:0x33e} (child of &etcd.Node{Key:"", Value:"", Dir:true, Expiration:(*time.Time)(nil), TTL:0, Nodes:etcd.Nodes{(*etcd.Node)(0xc2085e8060), (*etcd.Node)(0xc2085e80c0)}, ModifiedIndex:0x0, CreatedIndex:0x0})
F1222 11:46:58.802390   20535 etcd.go:39] Unable to delete key: 100: Key not found (/kubernetes.io) [1113]

#6065
re[test][extended:ldap_groups]

openshift-bot · 2015-12-22T17:45:21Z

Evaluated for origin test up to 6eb1b36

openshift-bot · 2015-12-22T18:55:21Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8081/) (Extended Tests: ldap_groups)

deads2k · 2015-12-22T19:03:36Z

[merge]

openshift-bot · 2015-12-22T19:05:31Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4463/) (Image: devenv-rhel7_3022)

openshift-bot · 2015-12-22T19:05:31Z

Evaluated for origin merge up to 6eb1b36

…ommands Merged by openshift-bot

stevekuznetsov force-pushed the skuznets/promote-group-commands branch from 4367a40 to b60c459 Compare December 17, 2015 15:47

stevekuznetsov mentioned this pull request Dec 17, 2015

updated LDAP group sync/prune references openshift/openshift-docs#1363

Merged

stevekuznetsov force-pushed the skuznets/promote-group-commands branch 2 times, most recently from 97a9b92 to e528c92 Compare December 17, 2015 16:05

stevekuznetsov force-pushed the skuznets/promote-group-commands branch from e528c92 to 467cbd6 Compare December 17, 2015 16:31

stevekuznetsov force-pushed the skuznets/promote-group-commands branch 2 times, most recently from 0d70520 to f7b2ed8 Compare December 17, 2015 19:45

stevekuznetsov force-pushed the skuznets/promote-group-commands branch from f7b2ed8 to 31b317a Compare December 21, 2015 14:28

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2015

stevekuznetsov force-pushed the skuznets/promote-group-commands branch from 0cb9af2 to a2fff3e Compare December 21, 2015 17:52

stevekuznetsov force-pushed the skuznets/promote-group-commands branch from a2fff3e to e0c4b4e Compare December 21, 2015 17:57

stevekuznetsov mentioned this pull request Dec 21, 2015

fix group-sync help text #5099

Closed

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2015

deads2k reviewed Dec 21, 2015
View reviewed changes

promoted group prune and sync from experimental

6eb1b36

stevekuznetsov force-pushed the skuznets/promote-group-commands branch from e0c4b4e to 6eb1b36 Compare December 21, 2015 19:57

openshift-bot pushed a commit that referenced this pull request Dec 22, 2015

Merge pull request #6369 from stevekuznetsov/skuznets/promote-group-c…

da443e7

…ommands Merged by openshift-bot

openshift-bot merged commit da443e7 into openshift:master Dec 22, 2015

stevekuznetsov deleted the skuznets/promote-group-commands branch January 8, 2016 15:22

promoted group prune and sync from experimental #6369

promoted group prune and sync from experimental #6369

Conversation

stevekuznetsov commented Dec 17, 2015

stevekuznetsov commented Dec 17, 2015

deads2k commented Dec 17, 2015

deads2k commented Dec 17, 2015

deads2k commented Dec 17, 2015

stevekuznetsov commented Dec 17, 2015

deads2k commented Dec 17, 2015

stevekuznetsov commented Dec 17, 2015

deads2k commented Dec 17, 2015

stevekuznetsov commented Dec 17, 2015

stevekuznetsov commented Dec 18, 2015

stevekuznetsov commented Dec 18, 2015

stevekuznetsov commented Dec 18, 2015

stevekuznetsov commented Dec 18, 2015

deads2k commented Dec 18, 2015

0xmichalis commented Dec 18, 2015

0xmichalis commented Dec 18, 2015

stevekuznetsov commented Dec 19, 2015

stevekuznetsov commented Dec 21, 2015

deads2k commented Dec 21, 2015

deads2k commented Dec 21, 2015

stevekuznetsov commented Dec 21, 2015

deads2k commented Dec 21, 2015

stevekuznetsov commented Dec 21, 2015

stevekuznetsov commented Dec 21, 2015

deads2k commented Dec 21, 2015

deads2k Dec 21, 2015

Choose a reason for hiding this comment

deads2k commented Dec 21, 2015

stevekuznetsov commented Dec 21, 2015

stevekuznetsov commented Dec 22, 2015

stevekuznetsov commented Dec 22, 2015

stevekuznetsov commented Dec 22, 2015

stevekuznetsov commented Dec 22, 2015

liggitt commented Dec 22, 2015

stevekuznetsov commented Dec 22, 2015

liggitt commented Dec 22, 2015

stevekuznetsov commented Dec 22, 2015

stevekuznetsov commented Dec 22, 2015

openshift-bot commented Dec 22, 2015

openshift-bot commented Dec 22, 2015

deads2k commented Dec 22, 2015

openshift-bot commented Dec 22, 2015

openshift-bot commented Dec 22, 2015