-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promoted group prune and sync from experimental #6369
promoted group prune and sync from experimental #6369
Conversation
[test][extended:ldap_groups] |
4367a40
to
b60c459
Compare
Link to the doc updates please. |
Update your description to show where this moved to and from. |
Also, since we doc'ed it, maintain the location under |
97a9b92
to
e528c92
Compare
@deads2k doc PR made, re-instated |
Add test for all four flavors in |
Which bucket should I put that into? |
put it in help |
e528c92
to
467cbd6
Compare
[test] |
0d70520
to
f7b2ed8
Compare
again #6259... |
re[test][extended:ldap_groups] |
@deads2k finally got green |
lgtm. @liggitt any complaint on the name? |
Shouldn't groups prune be a part of the existing prune command? |
Also are these two commands what 6276 is asking for? |
@deads2k should we put |
You'll know it when you see it. |
@stevekuznetsov cross link prune to support all three calling locations. Add the new location to |
@deads2k what should doc look like? |
Let's keep congruence, so |
f7b2ed8
to
31b317a
Compare
0cb9af2
to
a2fff3e
Compare
@deads2k rebased, re[test][extended:ldap_groups] |
a2fff3e
to
e0c4b4e
Compare
I don't understand. Go back in your |
$ oadm groups sync --whitelist=/path/to/whitelist.txt --sync-config=/path/to/sync-config.yaml | ||
|
||
# Sync all OpenShift Groups that have been synced previously with an LDAP server | ||
$ oadm groups sync --existing --sync-config=/path/to/ldap-sync-config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to regenerate
I think I understand now. Get yourself back to green. |
e0c4b4e
to
6eb1b36
Compare
updated docs & completions, re[test][extended:ldap_groups] |
re[test][extended:ldap_groups] |
I think the real error is:
|
@liggitt That seems more likely. Any opposition to me refactoring |
No strong opposition... I'd maybe start with just the ones capturing/echoing output to make the review easy, since that's the main issue that is making our lives difficult at the moment |
re[test][extended:ldap_groups] |
#6065 |
Evaluated for origin test up to 6eb1b36 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8081/) (Extended Tests: ldap_groups) |
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4463/) (Image: devenv-rhel7_3022) |
Evaluated for origin merge up to 6eb1b36 |
…ommands Merged by openshift-bot
ref #6276
This PR promotes
openshift ex {sync,prune}-groups
tooadm groups {sync,prune}
@deads2k PTAL