-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten image importer dialTimeout to 5 seconds #6418
Shorten image importer dialTimeout to 5 seconds #6418
Conversation
[test] |
@deads2k @stevekuznetsov PTAL |
Evaluated for origin test up to b8ad889 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8006/) |
green jenkins... mysql:latest import was much better (~10 seconds) this was still longer than I'd like, but I expect @deads2k's changes (parallel and abandoning NotFound imports) will significantly improve this:
|
Merging to help the queue. Would still like review and can adjust in a follow up if needed |
[merge] |
Fun... flakes blocking flake fixes - #6065
[merge] |
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4436/) (Image: devenv-rhel7_3003) |
Evaluated for origin merge up to b8ad889 |
Merged by openshift-bot
@@ -63,7 +63,7 @@ func retryWhenUnreachable(t *testing.T, f func() error) error { | |||
} | |||
|
|||
func TestRegistryClientConnect(t *testing.T) { | |||
c := dockerregistry.NewClient() | |||
c := dockerregistry.NewClient(10 * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I get some constants in the update? This looks a little silly. DefaultTimeout
or something. Even a separate constructor for the 90% who don't care.
Related to #6381
Related to #6259