Shorten image importer dialTimeout to 5 seconds

[liggitt]

Related to #6381
Related to #6259

[liggitt]

[test]

[liggitt]

@deads2k @stevekuznetsov PTAL
Once the parallel image import goes in, I would consider lengthening this to 10 seconds
Left as 10 seconds in the unit tests, and the original 30 seconds in the new-app client

[openshift-bot]

Evaluated for origin test up to b8ad889

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8006/)

[liggitt]

green jenkins... mysql:latest import was much better (~10 seconds)

this was still longer than I'd like, but I expect @deads2k's changes (parallel and abandoning NotFound imports) will significantly improve this:

SUCCESS after 42.423s: hack/../test/cmd/newapp.sh:143: executing 'oc get imagestreamtags installable:file' expecting success; re-trying every 0.2s until completion or 60.000s

[liggitt]

Merging to help the queue. Would still like review and can adjust in a follow up if needed

[liggitt]

[merge]

[liggitt]

Fun... flakes blocking flake fixes - #6065

I1219 14:52:03.014415   21047 etcd.go:37] Deleting &etcd.Node{Key:"/kubernetes.io", Value:"", Dir:true, Expiration:(*time.Time)(nil), TTL:0, Nodes:etcd.Nodes(nil), ModifiedIndex:0x348, CreatedIndex:0x348} (child of &etcd.Node{Key:"", Value:"", Dir:true, Expiration:(*time.Time)(nil), TTL:0, Nodes:etcd.Nodes{(*etcd.Node)(0xc2086b8060), (*etcd.Node)(0xc2086b80c0)}, ModifiedIndex:0x0, CreatedIndex:0x0})
I1219 14:52:07.248341   21047 etcd.go:37] Deleting &etcd.Node{Key:"/openshift.io", Value:"", Dir:true, Expiration:(*time.Time)(nil), TTL:0, Nodes:etcd.Nodes(nil), ModifiedIndex:0x34f, CreatedIndex:0x34f} (child of &etcd.Node{Key:"", Value:"", Dir:true, Expiration:(*time.Time)(nil), TTL:0, Nodes:etcd.Nodes{(*etcd.Node)(0xc2086b8060), (*etcd.Node)(0xc2086b80c0)}, ModifiedIndex:0x0, CreatedIndex:0x0})
F1219 14:52:14.653034   21047 etcd.go:39] Unable to delete key: 100: Key not found (/openshift.io) [1124]

[merge]

[liggitt]

#6031

test-cmd.sh
Logging to /tmp/openshift-cmd/MPVw/logs...
openshift: openshift v1.1-582-g0add922 kubernetes v1.1.0-origin-1107-g4c8e6f4 etcd 2.1.2
[INFO] Create certificates for the OpenShift server to /tmp/openshift-cmd/MPVw/openshift.local.config/master
Generated new key pair as /tmp/openshift-cmd/MPVw/openshift.local.config/master/serviceaccounts.public.key and /tmp/openshift-cmd/MPVw/openshift.local.config/master/serviceaccounts.private.key
Generating node credentials ...
Created node config for 172.18.4.199 in /tmp/openshift-cmd/MPVw/openshift.local.config/node-172.18.4.199
Wrote master config to: /tmp/openshift-cmd/MPVw/openshift.local.config/master/master-config.yaml
Generating node credentials ...
Created node config for 172.18.4.199 in /tmp/openshift-cmd/MPVw/openshift.local.config/node-172.18.4.199
validation: ok
ERROR: gave up waiting for https://127.0.0.1:28443/healthz

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4436/) (Image: devenv-rhel7_3003)

[openshift-bot]

Evaluated for origin merge up to b8ad889

[deads2k]

Can I get some constants in the update? This looks a little silly. DefaultTimeout or something. Even a separate constructor for the 90% who don't care.