Fix dind compatibility with centos/rhel #6543
Conversation
|
Evaluated for origin testonlyextended up to f423c67 |
|
continuous-integration/openshift-jenkins/testonlyextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8191/) (Extended Tests: networking) |
|
cc: @mrunalp |
|
[test][extended:core] |
Kubelet's cgroup manipulation of the dind daemon is not compatible with centos/rhel. This change disables the offending cgroup manipulation when the kubelet is running with dind.
marun
force-pushed
the
dind-rhel-compat
branch
from
f423c67
to
04ca9d5
Compare
|
Evaluated for origin test up to 04ca9d5 |
|
cc: @eparis @rajatchopra @pravisankar @danmcp Please prioritize getting this merged. As per the testonlyextended SUCCESS from a couple of days ago, this change enables pre-merge execution of the networking extended tests. |
|
[merge] this only touches the dind testing stuff. |
| // | ||
| // TODO(marun) Make dind cgroups compatible with openshift | ||
| // This workaround should become unnecessary once user namespaces | ||
| if value := cmdutil.Env("OPENSHIFT_DIND", ""); value == "true" { |
There was a problem hiding this comment.
we should back out this change. Env vars shouldn't be part of the input to building runtime config from serialized config... it makes config non-deterministic
There was a problem hiding this comment.
that's a fair request, can you open an issue
There was a problem hiding this comment.
I don't think this should be backed out without an alternate solution, since it is required for networking ci to prevent regressions. What alternative approach to disabling the kubelet's broken cgroup manipulation would you suggest?
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/8280/) (Extended Tests: core) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4562/) (Image: devenv-rhel7_3099) |
|
[merge] flake flake flake flake flake |
|
Evaluated for origin merge up to 04ca9d5 |
Kubelet's cgroup manipulation of the dind daemon is not compatible with
centos/rhel. This change disables the offending cgroup manipulation
when the kubelet is running with dind.