-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve api groups in resolveresource #8280
Resolve api groups in resolveresource #8280
Conversation
|
||
partialResource := unversioned.GroupVersionResource{Resource: strings.ToLower(resourceGroupParts[0])} | ||
if len(resourceGroupParts) > 1 { | ||
partialResource.Group = resourceGroupParts[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lower the group while you're here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oc get hpa.Autoscaling
doesn't lowercase group to work... I'm not sure I want to enable incorrect groups to work here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed with @liggitt - at any case we should not diverge from kubectl
[test] |
if groupResource != gvr.GroupResource() { | ||
return "", "", &meta.AmbiguousResourceError{PartialResource: partialResource, MatchingResources: gvrs} | ||
} | ||
// Allow specifying the group the same way kubectl does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be ideal if we would re-use the code from there for all the parsing we do here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be ideal if we would re-use the code from there for all the parsing we do here.
ParseResourceArg
LGTM |
[merge] |
flake on #6040, re[test] |
Evaluated for origin test up to 49ad7cc |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2605/) |
Yum timeout, re[merge] |
flake #6533 [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5489/) (Image: devenv-rhel7_3877) |
now network flake [merge] |
Evaluated for origin merge up to 49ad7cc |
Fixes #7117