don't require a buildconfig label on build objects #9527
Conversation
|
[test] |
| @@ -20,7 +20,7 @@ type SerialPolicy struct { | |||
| func (s *SerialPolicy) IsRunnable(build *buildapi.Build) (bool, error) { | |||
| bcName := buildutil.ConfigNameForBuild(build) | |||
| if len(bcName) == 0 { | |||
| return false, NewNoBuildConfigLabelError(build) | |||
| return true, nil | |||
There was a problem hiding this comment.
hrm, does this mean that creating a build directly will cause the build to schedule immediately?
There was a problem hiding this comment.
*build without build config
There was a problem hiding this comment.
(I think it might be OK, as there is no BC associated to build which means those builds should have parallel policy)
There was a problem hiding this comment.
yes, that was the intent.. if you're creating one off builds, you don't get a scheduling policy since we have no idea what other builds it should be scheduled against.
|
test flake #9548 |
|
@mfojtik anything else? |
|
[test] |
|
[test] Ben Parees | OpenShift
|
|
Evaluated for origin test up to 09f86e4 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5412/) |
|
@mfojtik bump for monday morning. |
|
LGTM [merge] |
|
[merge] |
1 similar comment
|
[merge] |
|
[merge] On Mon, Jun 27, 2016 at 7:20 PM, OpenShift Bot notifications@github.com
Ben Parees | OpenShift |
|
[merge] On Mon, Jun 27, 2016 at 10:55 PM, OpenShift Bot notifications@github.com
Ben Parees | OpenShift |
|
[merge] Ben Parees | OpenShift
|
|
@bparees merge spree :-) [merge] |
|
@mfojtik i'm going for a record. |
|
[merge] |
1 similar comment
|
[merge] |
|
Evaluated for origin merge up to 09f86e4 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5412/) (Image: devenv-rhel7_4479) |
No description provided.