Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster up: override port forwarding if using docker machine #9993

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jul 22, 2016

Using a docker machine should take precedence over the port forwarding setting.

@csrwng
Copy link
Contributor Author

csrwng commented Jul 22, 2016

@bparees ptal
@spadgett fyi

@bparees
Copy link
Contributor

bparees commented Jul 22, 2016

lgtm [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 8833701

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6732/)

@csrwng
Copy link
Contributor Author

csrwng commented Jul 22, 2016

Opened issue for test flake: #9999

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 24, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6830/) (Image: devenv-rhel7_4662)

@csrwng
Copy link
Contributor Author

csrwng commented Jul 25, 2016

flakes:
#9548
#9490
#9959

@csrwng
Copy link
Contributor Author

csrwng commented Jul 25, 2016

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 8833701

@openshift-bot openshift-bot merged commit 31be83e into openshift:master Jul 25, 2016
@csrwng csrwng deleted the clusterup_dm_fix branch December 21, 2016 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants