Add an e2e-openstack job #1824
Add an e2e-openstack job #1824
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
flaper87
force-pushed
the
openstack
branch
2 times, most recently
from
ba55d30
to
341c711
Compare
ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
Show resolved
Hide resolved
| name: pull-ci-openshift-installer-master-e2e-openstack | ||
| optional: true | ||
| rerun_command: /test e2e-openstack | ||
| run_if_changed: ^([^d]|d(d|o(d|cd))*([^do]|o([^cd]|c[^ds])))*(d(d|o(d|cd))*(oc?)?)?$ |
There was a problem hiding this comment.
Copied it from the aws one. Let me ask you a couple of questions:
- Should
run_if_changedbe set? - What should it be set to?
There was a problem hiding this comment.
removed this line for now. I'd appreciate some info about how to use it properly, tho. Thanks a bunch
There was a problem hiding this comment.
You shouldn't need it
| skip_cloning: true | ||
| spec: | ||
| containers: | ||
| - command: |
There was a problem hiding this comment.
Use
- command:
- ci-operator
- args:
- --give...| name: cluster-profile | ||
| - mountPath: /usr/local/e2e-openstack | ||
| name: job-definition | ||
| subPath: cluster-launch-installer-e2e.yaml |
There was a problem hiding this comment.
@bbguimaraes do we generate this one?
There was a problem hiding this comment.
The template, yes, but not the profile (which doesn't seem to exist).
There was a problem hiding this comment.
OK, can you help @flaper87 use the generator here
There was a problem hiding this comment.
@stevekuznetsov any points on how to use the generator? As I mentioned in the PR description, I'll need some guidance as I'm new to the community and the infrastructure.
thanks a bunch for your reviews! 👍
There was a problem hiding this comment.
I ran ./hack/update-generated-config.sh
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Since the job is optional, I think it's fine to merge it and then improve it in subsequent patches as needed. I still have to upload the credentials for it to be able to run loads on an OpenStack cloud. I'm figuring that out in parallel. |
|
@flaper87: we can already generate jobs for this template, but the openstack cluster profile is still not in the generator's list. Regardless of auto-generation, you will need to get the cluster profile in the repository (here) to be able to use it in E2E tests. After that, if the profile is meant to be used by other jobs and you want to be able to auto-generate jobs, you can take a look at this PR where new cluster profiles are being added to the generator. |
@wking can you provide some guidance here? I looked into the existing profiles but it seems they serve a different purpose. Does the existing |
|
@wking @bbguimaraes can you help me understand what the next step on this PR is? I'm a bit confused on whether a profile is actually needed and how that should be done if so. thanks 😄 |
Hey, thanks a lot! I'll add the missing case. I've tested this job with @sallyom's tool already and it seemed to get as far as I expected it to get. I'll do more tests today and report back. Thanks a bunch! |
|
@wking I've pushed a new version and added the missing case and a few other env vars that are required. I've tested this job with @sallyom One thing that is missing are the OpenStack credentials. Who should I talk to to upload those credentials to |
|
/test generated-config |
1 similar comment
|
/test generated-config |
|
Added the openstack profile to openshift/ci-operator-prowgen#40 |
|
/test generated-config |
ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
Outdated
Show resolved
Hide resolved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, flaper87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@flaper87: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is far from done but I thought I'd throw it out there to get some feedback and guidance