Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-20388: fix: updating 4.12 and 4.13 to golang 1.20 #44604

Merged
merged 1 commit into from
Oct 20, 2023
Merged

OCPBUGS-20388: fix: updating 4.12 and 4.13 to golang 1.20 #44604

merged 1 commit into from
Oct 20, 2023

Conversation

jeff-roche
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

@jeff-roche: This pull request references Jira Issue OCPBUGS-20544, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jeff-roche: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-lvm-operator-release-4.12-ci-index-lvm-operator-static-deps openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-release-4.12-images openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-release-4.12-lvm-operator-bundle-e2e-aws openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-release-4.12-unit-test openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-release-4.13-ci-index-lvm-operator-static-deps openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-release-4.13-images openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-release-4.13-lvm-operator-bundle-e2e-aws openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-release-4.13-unit-test openshift/lvm-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@jeff-roche jeff-roche changed the title OCPBUGS-20544: fix: updating 4.12 and 4.13 to golang 1.20 OCPBUGS-20388: fix: updating 4.12 and 4.13 to golang 1.20 Oct 19, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

@jeff-roche: This pull request references Jira Issue OCPBUGS-20388, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 19, 2023
@jeff-roche
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jeff-roche: This pull request references Jira Issue OCPBUGS-20388, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 19, 2023
@openshift-ci openshift-ci bot requested a review from radeore October 19, 2023 15:53
@jeff-roche
Copy link
Contributor Author

/assign @jakobmoellerdev @suleymanakbas91

@jeff-roche
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 19, 2023
@jakobmoellerdev
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 8985f54 into openshift:master Oct 20, 2023
@openshift-ci-robot
Copy link
Contributor

@jeff-roche: Jira Issue OCPBUGS-20388: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20388 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche jeff-roche deleted the lvms-pipeline-go-updates branch October 20, 2023 11:41
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@suleymanakbas91 suleymanakbas91 Awaiting requested review from suleymanakbas91

@radeore radeore Awaiting requested review from radeore

Assignees

@suleymanakbas91 suleymanakbas91

@jakobmoellerdev jakobmoellerdev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeff-roche @openshift-ci-robot @jakobmoellerdev @suleymanakbas91