Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33244: Change LVMS base image to fix openssl conflicts #51635

Merged
merged 1 commit into from
May 3, 2024
Merged

OCPBUGS-33244: Change LVMS base image to fix openssl conflicts #51635

merged 1 commit into from
May 3, 2024

Conversation

suleymanakbas91
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@suleymanakbas91
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@suleymanakbas91: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@suleymanakbas91
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@suleymanakbas91: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
@suleymanakbas91
fix: change LVMS base image to fix openssl conflicts
d650460 
Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
@suleymanakbas91 suleymanakbas91 marked this pull request as ready for review May 3, 2024 14:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@suleymanakbas91 suleymanakbas91 changed the title fix: change LVMS base image to fix openssl conflicts OCPBUGS-33244: Change LVMS base image to fix openssl conflicts May 3, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 3, 2024
@openshift-ci-robot
Copy link
Contributor

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-33244, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from radeore May 3, 2024 14:54
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@suleymanakbas91: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-lvm-operator-main-ci-index-lvm-operator-bundle openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-images openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-lvm-operator-e2e-aws openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-lvm-operator-e2e-aws-sno openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-precommit-check openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-snyk-code openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-snyk-deps openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-unit-test openshift/lvm-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from eggfoobar and qJkee May 3, 2024 15:02
jakobmoellerdev
jakobmoellerdev approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@suleymanakbas91
Copy link
Contributor Author

/pj-rehearse ack

1 similar comment
@suleymanakbas91
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@suleymanakbas91: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 3, 2024
@suleymanakbas91
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 43e4cb7 into openshift:master May 3, 2024
14 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

@suleymanakbas91: Jira Issue OCPBUGS-33244: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-33244 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 3, 2024
Merged
jbpratt pushed a commit to jbpratt/release that referenced this pull request May 30, 2024
@suleymanakbas91 @jbpratt
fix: change LVMS base image to fix openssl conflicts (openshift#51635)
b9ee0ac 
Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

@radeore radeore Awaiting requested review from radeore

@eggfoobar eggfoobar Awaiting requested review from eggfoobar

@qJkee qJkee Awaiting requested review from qJkee

Assignees

@jakobmoellerdev jakobmoellerdev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suleymanakbas91 @openshift-ci-robot @jakobmoellerdev