Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer/presubmit: adding a job to force disalbe BYO IP #56114

Merged
merged 1 commit into from
Aug 30, 2024
Merged

installer/presubmit: adding a job to force disalbe BYO IP #56114

merged 1 commit into from
Aug 30, 2024

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Aug 30, 2024 •
edited
Loading

Creating an job to test clusters without BYO Public IPv4 (default) on PR openshift/installer#8676 .
BYO Public IP pool is enabled by default over AWS jobs, and it wont use it when the job is full. This change enforce to not use the pool to test the feature on CAPI/installer.

@openshift-ci openshift-ci bot requested review from barbacbd and jhixson74 August 30, 2024 00:43
@mtulio
Copy link
Contributor Author

mtulio commented Aug 30, 2024

/pj-rehearse pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-public-ipv4-pool-disabled

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Aug 30, 2024

Install is passing:

BYOIP custom IP pool use explicitly disabled with AWS_PUBLIC_IPV4_POOL_ID=none; skipping
  • bootstrap node get an Public IPv4 outside the pool:
time="2024-08-30T01:21:09Z" level=debug msg="Checking that IP addresses are populated in the status of machine ci-op-vcm4mzj2-df2f2-nqg2k-bootstrap..."
time="2024-08-30T01:21:09Z" level=debug msg="Checked IP InternalDNS: ip-10-0-188-18.us-west-1.compute.internal"
time="2024-08-30T01:21:09Z" level=debug msg="Checked IP InternalIP: 10.0.188.18"
time="2024-08-30T01:21:09Z" level=debug msg="Checked IP ExternalDNS: ec2-54-183-203-23.us-west-1.compute.amazonaws.com"
time="2024-08-30T01:21:09Z" level=debug msg="Found external IP address: 54.183.203.23"

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 30, 2024
@mtulio mtulio force-pushed the add-pull-byoip-none branch from 09add75 to 782dfe2 Compare August 30, 2024 01:56
@mtulio
Copy link
Contributor Author

mtulio commented Aug 30, 2024

/pj-rehearse pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-public-ipv4-pool-disabled

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Aug 30, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Aug 30, 2024

PTAL?
/assign @r4f4 @patrickdillon

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 30, 2024
r4f4
r4f4 suggested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add this job to the normal config. The altinfra variant should be going away soon.

ci-operator/config/openshift/installer/openshift-installer-master__altinfra.yaml Outdated Show resolved Hide resolved
@mtulio mtulio force-pushed the add-pull-byoip-none branch from 782dfe2 to 4363d7c Compare August 30, 2024 11:53
@mtulio
Copy link
Contributor Author

mtulio commented Aug 30, 2024

/assign @r4f4
/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
OCPBUGS-36293? installer/presubmit: add aws job to disalbe BYO IP
10c3396 
Introduce a periodic on installer to force disable the step config of BYO
Public IPv4 Pool on install-config.yaml.

This new job is optional and can be used to validate the variant of an
installation without BYO Public IPv4 configuration on CAPA - the default
CI AWS workflows are enforcing Public IPv4 to save costs of IPv4
charges.
@mtulio mtulio force-pushed the add-pull-byoip-none branch from 4363d7c to 10c3396 Compare August 30, 2024 14:53
@mtulio
Copy link
Contributor Author

mtulio commented Aug 30, 2024

@r4f4 moved jobs from altinfra to master.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-aws-ovn-public-ipv4-pool openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-master-e2e-aws-ovn-public-ipv4-pool-disabled openshift/installer presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio
Copy link
Contributor Author

mtulio commented Aug 30, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 30, 2024
r4f4
r4f4 reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@vr4manta
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, r4f4, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3944488 into openshift:master Aug 30, 2024
17 checks passed
@mtulio mtulio deleted the add-pull-byoip-none branch August 30, 2024 20:38
This was referenced Aug 30, 2024
Merged
Merged
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 4, 2024
@mtulio @MiguelCarpio
OCPBUGS-36293? installer/presubmit: add aws job to disalbe BYO IP (op…
34bf5cb 
…enshift#56114)

Introduce a periodic on installer to force disable the step config of BYO
Public IPv4 Pool on install-config.yaml.

This new job is optional and can be used to validate the variant of an
installation without BYO Public IPv4 configuration on CAPA - the default
CI AWS workflows are enforcing Public IPv4 to save costs of IPv4
charges.
giladravid16 pushed a commit to giladravid16/release that referenced this pull request Sep 5, 2024
@mtulio @giladravid16
OCPBUGS-36293? installer/presubmit: add aws job to disalbe BYO IP (op…
0d815b2 
…enshift#56114)

Introduce a periodic on installer to force disable the step config of BYO
Public IPv4 Pool on install-config.yaml.

This new job is optional and can be used to validate the variant of an
installation without BYO Public IPv4 configuration on CAPA - the default
CI AWS workflows are enforcing Public IPv4 to save costs of IPv4
charges.
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 12, 2024
@mtulio @MiguelCarpio
OCPBUGS-36293? installer/presubmit: add aws job to disalbe BYO IP (op…
e0dbdc6 
…enshift#56114)

Introduce a periodic on installer to force disable the step config of BYO
Public IPv4 Pool on install-config.yaml.

This new job is optional and can be used to validate the variant of an
installation without BYO Public IPv4 configuration on CAPA - the default
CI AWS workflows are enforcing Public IPv4 to save costs of IPv4
charges.
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Sep 24, 2024
@mtulio @obochan-rh
OCPBUGS-36293? installer/presubmit: add aws job to disalbe BYO IP (op…
5ba08d2 
…enshift#56114)

Introduce a periodic on installer to force disable the step config of BYO
Public IPv4 Pool on install-config.yaml.

This new job is optional and can be used to validate the variant of an
installation without BYO Public IPv4 configuration on CAPA - the default
CI AWS workflows are enforcing Public IPv4 to save costs of IPv4
charges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 requested changes

@barbacbd barbacbd Awaiting requested review from barbacbd

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@r4f4 r4f4

@vr4manta vr4manta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtulio @openshift-ci-robot @vr4manta @r4f4