Skip to content

Commit

Permalink
Merge pull request #2673 from openshift-cherrypick-robot/cherry-pick-…
Browse files Browse the repository at this point in the history
…2672-to-release_1.2.49

[release_1.2.49] OCM-12912 | fix: Combine all policies rather than eating the output
  • Loading branch information
hunterkepley authored Dec 3, 2024
2 parents 92aaaf5 + fe02aa3 commit d26a65a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cmd/dlt/accountroles/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ func deleteAccountRoles(r *rosa.Runtime, env string, prefix string, clusters []*
if roles.CheckIfRolesAreHcpSharedVpc(r, finalRoleList) &&
confirm.Prompt(true, "Create commands to delete Hosted CP shared VPC policies?") {
for _, role := range finalRoleList {
policiesOutput, err = r.AWSClient.GetPolicyDetailsFromRole(awssdk.String(role))
policies, err := r.AWSClient.GetPolicyDetailsFromRole(awssdk.String(role))
policiesOutput = append(policiesOutput, policies...)
if err != nil {
r.Reporter.Infof("There was an error getting details of policies attached to role '%s': %v",
role, err)
Expand Down

0 comments on commit d26a65a

Please sign in to comment.