Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release_1.2.49] OCM-12912 | fix: Combine all policies rather than eating the output #2673

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[release_1.2.49] OCM-12912 | fix: Combine all policies rather than eating the output #2673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/dlt/accountroles/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ func deleteAccountRoles(r *rosa.Runtime, env string, prefix string, clusters []*
if roles.CheckIfRolesAreHcpSharedVpc(r, finalRoleList) &&
confirm.Prompt(true, "Create commands to delete Hosted CP shared VPC policies?") {
for _, role := range finalRoleList {
policiesOutput, err = r.AWSClient.GetPolicyDetailsFromRole(awssdk.String(role))
policies, err := r.AWSClient.GetPolicyDetailsFromRole(awssdk.String(role))
policiesOutput = append(policiesOutput, policies...)
if err != nil {
r.Reporter.Infof("There was an error getting details of policies attached to role '%s': %v",
role, err)
Expand Down