Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: honor --exclude when using --as-dockerfile #1105

Merged
merged 3 commits into from
Mar 10, 2023
Merged

fix: honor --exclude when using --as-dockerfile #1105

merged 3 commits into from
Mar 10, 2023

Conversation

matejvasek
Copy link
Contributor

No description provided.

@matejvasek
refactor: Copy() takes a predicate not a set
a285530 
Predicate is more universal than a set (Go map).

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
fix: honor --exclude when using --as-dockerfile
73fe5b5 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

Maybe this removes need for filtering in tar type Tar interface ?

@matejvasek
Copy link
Contributor Author

@coreydaley any idea why the test is failing?

@coreydaley
Copy link
Member

looking

@matejvasek
fixup
0bc1f25 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

@matejvasek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matejvasek
Copy link
Contributor Author

@coreydaley ok, thanks, now test are passing.

@matejvasek matejvasek requested review from coreydaley and removed request for gabemontero March 9, 2023 22:39
@matejvasek
Copy link
Contributor Author

PTAL @coreydaley

@coreydaley
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit db599d2 into openshift:master Mar 10, 2023
@matejvasek matejvasek mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley coreydaley left review comments

Assignees

@coreydaley coreydaley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @coreydaley @openshift-merge-robot