-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task for list_all_resources.sh #800
base: master
Are you sure you want to change the base?
Add task for list_all_resources.sh #800
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mehabhalodiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mehabhalodiya For a script we can directly add it as a task in the reliability.yaml like this. |
6e77a0b
to
c18e581
Compare
@qiliRedHat, I made the changes per your suggestions. Please check and let me know. Thanks! |
@mehabhalodiya Please paste the related test results here when you get a chance to test it on a cluster. |
@@ -36,13 +36,16 @@ reliability: | |||
- func apply_nonamespace -p "<path_to_content>/network-policy/02_anp_allow-traffic-egress-cidr-cluster-network-p20.yaml" | |||
- func apply_nonamespace -p "<path_to_content>/network-policy/04_anp_allow-traffic-dev-test-p30.yaml" | |||
- func apply_nonamespace -p "<path_to_content>/network-policy/03_anp_allow-traffic-dev-prod-p31.yaml" | |||
- <path_to_script>/list_all_resources.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehabhalodiya To easily analysis the results (especially by an automation script), I think it is helpful to output the test results to a separate files with timestamp. Or else you have to find out the results in the reliability.log. You can do it in the script itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. @qiliRedHat You can refer to the below screenshot.
This is how it looks when we run the script: |
92bbf10
to
a5aa2a0
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
a5aa2a0
to
9bc0b15
Compare
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Remaining task for https://issues.redhat.com/browse/OCPQE-19542
FYI Added script #799