Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task for list_all_resources.sh #800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mehabhalodiya
Copy link
Contributor

Remaining task for https://issues.redhat.com/browse/OCPQE-19542

FYI Added script #799

@openshift-ci openshift-ci bot requested review from liqcui and rpattath November 26, 2024 19:05
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mehabhalodiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@qiliRedHat
Copy link
Contributor

@mehabhalodiya For a script we can directly add it as a task in the reliability.yaml like this.

@mehabhalodiya mehabhalodiya force-pushed the list-all-resources-task branch 2 times, most recently from 6e77a0b to c18e581 Compare November 27, 2024 10:53
@mehabhalodiya
Copy link
Contributor Author

@qiliRedHat, I made the changes per your suggestions. Please check and let me know. Thanks!

@qiliRedHat
Copy link
Contributor

@mehabhalodiya Please paste the related test results here when you get a chance to test it on a cluster.

@@ -36,13 +36,16 @@ reliability:
- func apply_nonamespace -p "<path_to_content>/network-policy/02_anp_allow-traffic-egress-cidr-cluster-network-p20.yaml"
- func apply_nonamespace -p "<path_to_content>/network-policy/04_anp_allow-traffic-dev-test-p30.yaml"
- func apply_nonamespace -p "<path_to_content>/network-policy/03_anp_allow-traffic-dev-prod-p31.yaml"
- <path_to_script>/list_all_resources.sh
Copy link
Contributor

@qiliRedHat qiliRedHat Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehabhalodiya To easily analysis the results (especially by an automation script), I think it is helpful to output the test results to a separate files with timestamp. Or else you have to find out the results in the reliability.log. You can do it in the script itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. @qiliRedHat You can refer to the below screenshot.

@mehabhalodiya
Copy link
Contributor Author

mehabhalodiya commented Dec 3, 2024

@mehabhalodiya Please paste the related test results here when you get a chance to test it on a cluster.

This is how it looks when we run the script:

Screenshot 2024-12-04 at 10 44 09 PM

@mehabhalodiya mehabhalodiya force-pushed the list-all-resources-task branch 4 times, most recently from 92bbf10 to a5aa2a0 Compare December 5, 2024 12:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
@mehabhalodiya mehabhalodiya force-pushed the list-all-resources-task branch from a5aa2a0 to 9bc0b15 Compare December 5, 2024 13:07
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants