Skip to content

Commit

Permalink
Timeout and TaskSpec supported in Custom Tasks
Browse files Browse the repository at this point in the history
We already designed and implemented support for 
`Timeouts` and `TaskSpec` in `Custom Tasks`. 

`Timeouts`:
- TEP: tektoncd/community#433
- PR: tektoncd#3976

`TaskSpec`:
- TEP: https://github.com/tektoncd/community/blob/main/teps/0061-allow-custom-task-to-be-embedded-in-pipeline.md
- PR: tektoncd#3901

This item cleans up the todo items in `RunSpec`.
  • Loading branch information
jerop authored and khrm committed May 19, 2022
1 parent f0db0a1 commit 291eb22
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/apis/pipeline/v1alpha1/run_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ type RunSpec struct {
// Workspaces is a list of WorkspaceBindings from volumes to workspaces.
// +optional
Workspaces []v1beta1.WorkspaceBinding `json:"workspaces,omitempty"`

// TODO(https://github.com/tektoncd/community/pull/128)
// - timeout
// - inline task spec
}

// RunSpecStatus defines the taskrun spec status the user can provide
Expand Down

0 comments on commit 291eb22

Please sign in to comment.