-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Login Screen Logo Size Configurable #3045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3045 +/- ##
=========================================
+ Coverage 64.5% 65.7% +1.1%
- Complexity 1075 1130 +55
=========================================
Files 218 235 +17
Lines 9635 10882 +1247
Branches 1897 1985 +88
=========================================
+ Hits 6218 7153 +935
- Misses 2234 2477 +243
- Partials 1183 1252 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dubdabasoduba
previously approved these changes
Feb 7, 2024
dubdabasoduba
approved these changes
Feb 7, 2024
AbdulWahabMemon
added a commit
that referenced
this pull request
Feb 9, 2024
* main: Add icons to be displayed on eusm service point register. (#3047) Upgrade sdk libraries to latest versions (#2825) Make Login Screen Logo Size Configurable (#3045) # Conflicts: # android/gradle/libs.versions.toml # android/quest/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivity.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Required to match mockup mentioned in here
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file