Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Login Screen Logo Size Configurable #3045

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Conversation

hamza-vd
Copy link
Contributor

@hamza-vd hamza-vd commented Feb 7, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Required to match mockup mentioned in here

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 414 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (0afa08a) 65.7%.
Report is 166 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3045     +/-   ##
=========================================
+ Coverage     64.5%   65.7%   +1.1%     
- Complexity    1075    1130     +55     
=========================================
  Files          218     235     +17     
  Lines         9635   10882   +1247     
  Branches      1897    1985     +88     
=========================================
+ Hits          6218    7153    +935     
- Misses        2234    2477    +243     
- Partials      1183    1252     +69     
Flag Coverage Δ
engine 68.8% <62.7%> (-3.9%) ⬇️
geowidget 65.5% <ø> (+1.1%) ⬆️
quest 63.6% <ø> (+4.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ter/fhircore/engine/configuration/Configuration.kt 25.0% <100.0%> (ø)
...ngine/configuration/event/EventTriggerCondition.kt 50.0% <ø> (ø)
...r/fhircore/engine/configuration/event/EventType.kt 100.0% <ø> (ø)
...core/engine/configuration/view/ColumnProperties.kt 100.0% <ø> (ø)
...ngine/configuration/view/CompoundTextProperties.kt 100.0% <ø> (ø)
...ore/engine/configuration/view/DividerProperties.kt 23.5% <ø> (ø)
...rcore/engine/configuration/view/ImageProperties.kt 34.6% <ø> (ø)
...ircore/engine/configuration/view/ListProperties.kt 83.3% <ø> (ø)
...ngine/configuration/view/PersonalDataProperties.kt 0.0% <ø> (ø)
...hircore/engine/configuration/view/RowProperties.kt 0.0% <ø> (ø)
... and 111 more

... and 76 files with indirect coverage changes

dubdabasoduba
dubdabasoduba previously approved these changes Feb 7, 2024
@hamza-vd hamza-vd added the DNM DO NOT MERGE label Feb 7, 2024
@hamza-vd hamza-vd removed the DNM DO NOT MERGE label Feb 7, 2024
@hamza-vd hamza-vd merged commit 72e273e into main Feb 7, 2024
6 checks passed
@hamza-vd hamza-vd deleted the make-login-logo-configurable branch February 7, 2024 13:03
AbdulWahabMemon added a commit that referenced this pull request Feb 9, 2024
* main:
  Add icons to be displayed on eusm service point register. (#3047)
  Upgrade sdk libraries to latest versions (#2825)
  Make Login Screen Logo Size Configurable (#3045)

# Conflicts:
#	android/gradle/libs.versions.toml
#	android/quest/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireActivity.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants