Disable incremental counts & add support for returning 0 in multi-result queries #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults - Add exectedIndicators property for Multi-Result Indicator queries - Add migrations to add column for exected_indicators in indicator_queries table - Add sample multi-result query with expected_indicators - Enable reading the expected_indicators fields and saving it - Enable processing multi-result in case expectedIndicators have been defined and providing the expected output only Fixes #32
…ti-result queries - Break the previous functionality where multi-result data is edited before saving - Add tests for the new functionality The current functionality checks the retrieved multi-result data and compares it with the registered expectedIndicators Fixes #32
1. Check if there are multiple indicator tallies for a single day 2. Rewrite all values into the same table when the multiple indicator tallies are summed up
- Change date format for queries to Y-m-d from Y-m-d h:m:s - Perform queries every time the job runs and no only when a new event has been registered since the last event recorded - Save IndicatorTally date as Y-m-d for easy overwriting and queries Fixes #15
ekigamba
changed the title
ekigamba
force-pushed
the
issue/15-disable-incremental-counts
branch
from
79b1c07
to
1810d6f
Compare
ekigamba
force-pushed
the
issue/15-disable-incremental-counts
branch
2 times, most recently
from
aa009f2
to
8460df1
Compare
ekigamba
force-pushed
the
issue/15-disable-incremental-counts
branch
from
8460df1
to
01152f7
Compare
|
BLOCKED Waiting for #22 |
allan-on
reviewed
Oct 25, 2019
Comment on lines
390
to
391
| public static void aggregateDailyTallies(@NonNull SQLiteDatabase database) { | ||
| // Code to migrate the code over from incremental tallies should be written here |
There was a problem hiding this comment.
So with this implementation, does it mean https://github.com/OpenSRP/opensrp-client-reporting/blob/7257fb5d253ad1d23c9e8a0f5eb46d94a942ec24/opensrp-reporting/src/main/java/org/smartregister/reporting/repository/IndicatorQueryRepository.java#L171-L173 should be removed/deleted?
|
Yea, this should be deleted
…On Fri, Oct 25, 2019 at 4:18 PM Allan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
opensrp-reporting/src/main/java/org/smartregister/reporting/repository/DailyIndicatorCountRepository.java
<#33 (comment)>
:
> public static void ***@***.*** SQLiteDatabase database) {
// Code to migrate the code over from incremental tallies should be written here
So with this implementation, does it mean
https://github.com/OpenSRP/opensrp-client-reporting/blob/7257fb5d253ad1d23c9e8a0f5eb46d94a942ec24/opensrp-reporting/src/main/java/org/smartregister/reporting/repository/IndicatorQueryRepository.java#L171-L173
should be removed/deleted?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#33>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHSLMO6DZVWMKFP74QK24ATQQLWYRANCNFSM4ILSBG3A>
.
|
ekigamba
force-pushed
the
issue/15-disable-incremental-counts
branch
from
bd24498
to
e853012
Compare
ekigamba
force-pushed
the
issue/15-disable-incremental-counts
branch
from
a8bb84f
to
b8c43e1
Compare
allan-on
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Also resolves #32
Try and also solve the issue in #34