Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rm From<OwnedFd> for Stdio impl #82

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Rm From<OwnedFd> for Stdio impl #82

merged 1 commit into from
Jun 19, 2022

Conversation

NobodyXu
Copy link
Member

to avoid using io_lifetimes in public API.

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

@NobodyXu
Rm From<OwnedFd> for Stdio impl
c7867ba 
to avoid using `io_lifetimes` in public API.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from jonhoo June 14, 2022 03:15
@jonhoo
Copy link
Collaborator

jonhoo commented Jun 14, 2022

This change is Reviewable

@NobodyXu NobodyXu mentioned this pull request Jun 14, 2022
Merged
@NobodyXu
Copy link
Member Author

Looks like io-safety is finally going to be stablised in 1.63 rust-lang/rust#95118

@jonhoo Should we wait for it instead and replace the crate io-lifetimes with the std counterparts?

jonhoo
jonhoo approved these changes Jun 19, 2022
View reviewed changes
Copy link
Collaborator

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to remove it anyway in the interrim since as it stands it's a breaking change problem waiting to happen. Happy to add it back after 1.63 without the dependency.

src/stdio.rs Show resolved Hide resolved
@jonhoo jonhoo merged commit 57e33a4 into master Jun 19, 2022
@jonhoo jonhoo deleted the fix/remove-io-lifetime-in-pub-api branch June 19, 2022 04:20
@NobodyXu
Copy link
Member Author

I'd like to remove it anyway in the interrim since as it stands it's a breaking change problem waiting to happen. Happy to add it back after 1.63 without the dependency.

@jonhoo Shall we create a new release and yield all the other 0.9.* release to ensure that no one depends on it?

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 19, 2022

I don't think this is quite worth the (user) friction of a yank given that there isn't actually a security risk to this. The fact that there is a breaking change is going to be mostly irrelevant to users.

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 19, 2022

Released as 0.9.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhoo jonhoo jonhoo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NobodyXu @jonhoo