-
Notifications
You must be signed in to change notification settings - Fork 47
Regenerate go.mod indirect dependencies #724
Regenerate go.mod indirect dependencies #724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible we shouldn't introduce dependency on an unmaintained library, even if it's an indirect one.
Bumping zap to version 1.27 should get rid of it. As zap maintainers removed this dependency themselves over a year ago. uber-go/zap#1331
@@ -1,3 +1,4 @@ | |||
github.com/benbjohnson/clock v1.1.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library is no longer maintained.
We are already on zap 1.27 as per https://github.com/openstack-k8s-operators/dataplane-operator/pull/724/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R69 . But some of our deps are using older zap. Hence the go.sum line:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2
b5d416c
to
594176f
Compare
594176f
to
2907027
Compare
Given all the other approvals, let's followup the concern here with a separate PR if you feel strongly it needs to be addressed.
95ce840
to
2907027
Compare
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
During the golang version bump we unintentionally introduced a too new indirect dependency on kube-openapi: k8s.io/kube-openapi@v0.0.0-20240209001042-7a0d5b415232 This is not required by any of our direct deps and this is also a version that required golang 1.21. If your system has golang 1.21 installed the this dependency might force go mod tidy to change the golang version in the go.mod file to 1.21. This patch removed all the indirect dependencies and let go mod tidy to regenerate them to get rid of the too new kube-openapi version. This happened again in the bump dc2ba9b and revert 7a0ed7b of the cert-manager dependency.
2907027
to
14a12a3
Compare
and rebased again |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, fao89, gibizer, rebtoor, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
03eaf6d
into
openstack-k8s-operators:main
During the golang version bump we unintentionally introduced a too new
indirect dependency on kube-openapi:
k8s.io/kube-openapi@v0.0.0-20240209001042-7a0d5b415232
This is not required by any of our direct deps and this is also a
version that required golang 1.21. If your system has golang 1.21
installed the this dependency might force go mod tidy to change the
golang version in the go.mod file to 1.21.
This patch removed all the indirect dependencies and let go mod tidy to
regenerate them to get rid of the too new kube-openapi version.
This happened again in the bump dc2ba9b and revert 7a0ed7b of the
cert-manager dependency.