Skip to content

Commit

Permalink
Simplify session logger object tests
Browse files Browse the repository at this point in the history
With the requests-mock logger now configured to log the request[1],
checking that the logger output does *not* contain the request is
invalid. Simplify these two tests by omitting the assertion.

[1] jamielennox/requests-mock#93

Closes-bug: #1842978

Change-Id: If3c0447502917bce831d3e9f7ae4c31374dd4380
  • Loading branch information
cmurphy committed Sep 5, 2019
1 parent 38cd5fc commit 8b06c57
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions keystoneauth1/tests/unit/test_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,6 @@ def test_logger_object_passed(self):
self.assertIn(list(response.keys())[0], output)
self.assertIn(list(response.values())[0], output)

self.assertNotIn(self.TEST_URL, self.logger.output)
self.assertNotIn(list(response.keys())[0], self.logger.output)
self.assertNotIn(list(response.values())[0], self.logger.output)

Expand Down Expand Up @@ -1550,7 +1549,6 @@ def test_logger_object_passed(self):
self.assertIn(list(response.keys())[0], output)
self.assertIn(list(response.values())[0], output)

self.assertNotIn(self.TEST_URL, self.logger.output)
self.assertNotIn(list(response.keys())[0], self.logger.output)
self.assertNotIn(list(response.values())[0], self.logger.output)

Expand Down

0 comments on commit 8b06c57

Please sign in to comment.