[#92] Separate device logs #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
koral--
reviewed
Sep 15, 2019
|
|
||
| it('should ...', inject(function() { | ||
|
|
||
| //expect(SaveLogService.doSomething()).toEqual('something'); |
There was a problem hiding this comment.
There should be some tests perhaps
There was a problem hiding this comment.
Hi @koral--,
I didn't implemented any test, as I was not able to run jasmine and mocha tests. I will be happy to look at them. Is there any Dockerfile with setup of test environment on which I can start tests?
There was a problem hiding this comment.
There is nothing more apart from files available in this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposition for the issue described in the #92.
Steps to reproduce:
a) Assign first device and enable collecting adb logs
b) return to device list
c) select second device
Actual Results:
The logs for first device are displayed in the logcat textView.
Expected Results:
The logs should be separated between selected/assigned for the user devices
Changes contains:
#1077
#1074
Main changes in this PR:
Screenshots:
Save button
Save Modal
