Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add alternative dockerfiles for armhf and x86_64 architectures #1174

Merged
merged 1 commit into from
Feb 21, 2020
Merged

add alternative dockerfiles for armhf and x86_64 architectures #1174

merged 1 commit into from
Feb 21, 2020

Conversation

denis99999
Copy link
Contributor

Add alternative Dockerfiles based on debian operating system

@koral--
Copy link
Member

koral-- commented Feb 17, 2020

LGTM.
I think it is a good idea to check those Dockerfiles on CI.
I'm not familiar with cross-platform docker but AFAIK docker buildx can be used for that.
WDYT?

@denis99999
Copy link
Contributor Author

Hi @koral-- ,
I never tested buildx but it seems indeed to be a good track, althrough it is still an experimental feature which requires the 19.03 version of docker.
What I know is my Dockerfile for armhf is a little bit different as for x86_64, because it requires a more recent version of nodejs.

@koral-- koral-- mentioned this pull request Feb 21, 2020
Open
@koral--
Copy link
Member

koral-- commented Feb 21, 2020

OK, merging this as is.
I've added a separate issue for tracking CI of alternative dockerfiles: #1188

@koral-- koral-- merged commit d1f785e into openstf:master Feb 21, 2020
This was referenced Feb 21, 2020
Closed
Closed
@denis99999 denis99999 deleted the add-alternative-dockefiles branch February 28, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koral-- koral-- koral-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis99999 @koral--