-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show date of aerial data #2492
Comments
I suppose we could special case this for Bing, which has an API that purports to provide vintage, but in general our imagery sources don't come with this data. |
Do the Bing images themselves come with metadata in the response headers? As a host of imagery layers, I'd like to provide this information. |
The Bing response includes a line like this: |
👍 Would be nice to be able to pass some imagery metadata automatically, especially when adding custom background imagery (WMS/TMS from HOT-OSM Tasking Manager) and automatically add a source=* and source:date=YYYY-MM-DD to whatever element is created or modified with that specific imagery layer turned on. |
Even if the image tile comes with response headers indicating the vintage, we can't make use of them -- there's no way to get response headers for an |
Based on experience, the metadata for the middle is sufficient. The per-tile info is not perfectly accurate at imagery boundaries anyways. We should also make use of editor-imagery-index supplied dates. |
Hi @bhousel I talked with @gmaclennan about this, he has worked on something similar, here's what he had to say:
|
Nice! Thanks @aawiseman for pointing me at @gmaclennan's code... We could definitely perform that jsonp query to fetch the bing metadata. |
👍 for this feature. |
Now, can we inject that automatically to the source tag of any feature that is created off of the image layer being displayed? ;) |
We could add In fact when I map in New Jersey, I mostly use Bing even though the NJ 2015 Aerials are newer, simply because the Bing server loads much faster. I do swap between the two layers with ⌘B whenever I want a second look at something. My next thing I want to sneak into this panel - if it doesn't take too long - is #1124 - some support for the imagery offset database. |
I don't see why it should upset anyone. It would add a very useful piece of metadata that is often just left blank. Even if shown in the overlay box that you just added (:+1:), I don't think many people would take the time to copy and paste into the source tag of every feature they map. Adding it directly, as I'm suggesting, would be a major improvement in quality management of the map data. We should suggest adding the same function to JOSM as well 😉 Personally I would go even further, and advocate for making the |
Is it any plans to get the vintage for other aerial images to? Is it any standard (or best practices) that providers of aerial images can use to give that possibility? If not, it is anything that should be created? |
Maybe ask on the OSM mailing lists to see what people think about this? I don't have any strong opinion about it, but I know in my own mapping I probably wouldn't take the time to adjust the
If we can get the vintage from the other providers, I'll add code to do so. I think DigitalGlobe maps API might provide this information for the Standard layer (@kevinbullock may know?). DigitalGlobe Premium and Mapbox Satellite layer do not currently provide imagery vintage, as they are composites of several sources. (But they could eventually provide a date range the way that Bing does). Here is another cool screenshot - I'm adding imagery vintage to the tile debugging, and I'll add a button to toggle this display: |
@bhousel Just to let you know, using Ctrl+Shift+B as described in the keyboard shortcuts swaps between the background like when using Ctrl+B. Also, your changelog shows ⌘⇧B - you should really add the Windows shortcut as well 😉 |
In the next version, it should also be any way to toggle this and the other panels even if I don't remember the shortcuts. The panels is great, but I always forgot the shortcuts. Maybe create a separate issue for that? |
Thanks @boothym can you open up a new issue for this? The fix is probably to
Good suggestion - I agree, the changelog should show both. I try to write release notes for a broader audience now, since new releases link to it via the 🎁 icon. |
It's a good suggestion but I don't want to add buttons to the main iD user interface for these advanced features. iD's main strength is its simplicity, and the panel shortcuts are discoverable from the keyboard shortcuts screen ?. I have considered adding a button bar that only appears if the user has enabled the panels. This is partly because I'd like to better support mobile/tablet users someday. Right now I'm still waiting to see how this feature evolves, whether people use it, whether we add more of them, etc. |
I did not know this feature existed. It is very useful. I think it is even more useful now that it has been implemented to work with the ESRI World Imagery layer as well. I often get questions of users asking if there is a way to tell when the date when the imagery was collected. I would like to see the date of the imagery in the bottom bar (along where the scale is and the usernames are displayed). Or maybe in the bottom bar there can be a metadata icon that will display the metadata panel. Metadata is important! @bhousel @magol |
@bhousel did this feature (showing the date of the image) make it to the live system? I cannot find it in the editor. I am in a HOT task and wondering if a building was demolished or build from one image to the next. |
Yes it was merged to iD about a year ago.. Try using the Ctrl+Shift+B / Command+Shift+B key combo mentioned above to bring up the background info panel.. any luck? |
Yes, thanks, thats great. Btw, this image date feature might also be a thing to consider for osmlab/osm-planning#18. |
@bhousel For me in the UK, the date shows up on Bing, but not anymore for the Esri imagery - something has changed recently. The DG imagery has a "show vintage" button which then requires you to zoom out to see the yellow boxes/text, but it's always been like that. |
Thanks @boothym it looks like openstreetmap.org needed a rule added to allow the connection to the Esri metadata servers. @tomhughes fixed this today - thanks Tom! |
hey @bgirardot - the best place to discuss the Digital Globe vintage might be here: osmlab/editor-layer-index#371 There is some more info about them on that thread, and @marracci might be able to answer specific questions. If the imagery changes when you zoom in, then you're right that it's kind of impossible to date it this way. We all see these raster layers as kind of a "beta" feature, with the desired goal to either have a metadata server to query for more accurate results, or maybe store the metadata in vector tiles. |
also osmlab/osm-planning#18 has some more thoughts. I'd really like to build something to solve this! |
@bhousel I don't manage to see the image-dates for this are https://www.openstreetmap.org/edit?editor=id&#map=19/-4.44157/37.16185 - not for DG sources or Esri. I am pretty sure I tried all possible shortcut combinations (this time ;)). I cannot see any broken request in the network panel, so maybe I am really doing it wrong cause no API is requested? Or is it something else? Apart from the shortcut, is there a clickable way to activate this layer/info? |
Ah yeah I don't see them either. It looks like 2 separate problems. For the Esri layers, it would show the vintage on the Background Info Panel, and also on the tiles themselves, but apparently not working now. For the DG layers, you need to click "Show Vintage" and it will show some raster overlays. These are supposed to have the vintage dates on them, but they don't have them. |
@d3netxer If the dates aren't showing up in iD then it's most likely that they're not provided by Bing. |
Thanks. I now checked different cities around the world (Madrid, Paris, London, New York City, Lima, Sydney) and it is displaying at multiple zoom levels 'Vintage:Unknown'. |
When mapping in areas where demolition & construction is taking place,
and the map is different from the image, it would be useful to see
the date of aerial images shown.
The text was updated successfully, but these errors were encountered: