-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imperial units silently removed from ele tag #5658
imperial units silently removed from ele tag #5658
Comments
Nope. Space-separated units have been used in OSM since time immemorial and most major clients parse them, such as osm2pgsql, mkgmap, OSRM, Graphhopper etc. |
Right, regardless of whether it happens to be a "tagging mistake" in the "ele" field - this is something iD needs to support in all the numeric fields. I've actually been thinking of adding a "default units" property to each field that can have such a thing. There are a lot of them. But right now we include the default unit in the field label sometimes, and in the placeholder sometimes, but none of this is done consistently, and I'm sure it makes a mess for translators. https://github.com/openstreetmap/iD/blob/master/data/presets/fields/fire_hydrant/pressure.json |
The ideditor/schema-builder#15 requests a new field type for measured values, so that the Elevation field could display a dropdown menu for selecting meters or feet-and-inches. |
https://wiki.openstreetmap.org/wiki/Proposed_features/ele_with_units |
“(Meters)” was appended to the field name in openstreetmap/id-tagging-schema#95, which may decrease the likelihood of a user accidentally running into this trap, but regardless the field remains somewhat unintuitive in the United States. |
I was adding a peak from old OOC maps which have all elevation data in feet. I therefore entered 561 ft in the elevation field, so was somewhat surprised to find it rendered as 561 m. Testing shows that iD silenty strips any non-numeric text (including ",") from what is entered. Although ele:imperial is probably the most widely used tag for non-metric units, the ele tag with an indication of units (e.g., ft, feet, or "'") has always been in use. I would expect at least a warning, because there is a big difference between 561 feet & metres.
The text was updated successfully, but these errors were encountered: