Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outdoor_seating options #3730

Merged
merged 2 commits into from
Jan 10, 2017
Merged

Conversation

mertemin
Copy link
Contributor

@mertemin mertemin commented Jan 8, 2017

This PR adds outdoor_seating options following OSM wiki.

@bhousel
Copy link
Member

bhousel commented Jan 8, 2017

This PR adds outdoor_seating options following OSM wiki.

Looking at taginfo, I agree that it seems like yes/no are the only meaningful values for outdoor_seating and everything else is noise. Can we just make this field a checkbox?

@mertemin
Copy link
Contributor Author

Good call @bhousel. I updated the PR.

Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@@ -1106,7 +1106,14 @@
"outdoor_seating": {
"key": "outdoor_seating",
"type": "combo",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of placeholders and strings, just make this a "check"

@bhousel bhousel merged commit f96a595 into openstreetmap:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants