Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest duplicate commit messages #3759

Merged
merged 1 commit into from
Jan 16, 2017
Merged

Conversation

Abbe98
Copy link
Contributor

@Abbe98 Abbe98 commented Jan 13, 2017

This makes sure no duplicate commit messages are suggested.

The issue illustrated:
screen shot

I had to add a container variable to be able to use indexOf, the alternative would have been a loop as far as I know...

@bhousel bhousel merged commit 70f74c4 into openstreetmap:master Jan 16, 2017
@bhousel
Copy link
Member

bhousel commented Jan 16, 2017

Thanks! I changed it a little in 132a5b5 to use lodash _.uniqBy for simplicity.

@Abbe98
Copy link
Contributor Author

Abbe98 commented Jan 16, 2017

Thanks @bhousel didn't know about _.uniqBy :-)

@Abbe98
Copy link
Contributor Author

Abbe98 commented Jan 22, 2017

@tyrasd changeset comment suggestions seams to be working over at https://openstreetmap.us/iD/master/
image

@tyrasd
Copy link
Member

tyrasd commented Jan 22, 2017

ok, I see it now.

But, apparently, the API-0.6 changesets-call can be quite slow for users with many changesets. E.g. for me it takes around 5 to 6 seconds to load my last 100 changesets (for @manfredbrandl's account the situation is similar). And only after that the dropdown arrow will be shown.

Suggestion: Assuming that most users want to save their changes eventually, we could also load a user's changesets right after iD starts up (caching the contents locally), so that they're available immediately when the save-dialog is displayed.

@bhousel
Copy link
Member

bhousel commented Jan 22, 2017

Suggestion: Assuming that most users want to save their changes eventually, we could also load a user's changesets right after iD starts up (caching the contents locally), so that they're available immediately when the save-dialog is displayed.

This is a good idea...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants