Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add landuse=religious preset #4478

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Add landuse=religious preset #4478

merged 2 commits into from
Oct 27, 2017

Conversation

YuliiaVeklycheva
Copy link
Contributor

for #4476

bhousel
bhousel suggested changes Oct 27, 2017
View reviewed changes
Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor addition and then it's good to merge..

data/presets/presets/landuse/religious.json Outdated
"geometry": [
"area"
],
"tags": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thank you!
Can you also add a name field into this file too?

    "fields": [
        "name"
    ],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and then run npm run build again)

@YuliiaVeklycheva
Copy link
Contributor Author

@bhousel updated

@bhousel
Copy link
Member

bhousel commented Oct 27, 2017

Great thank you @YuliyaVeklicheva !
The name shows up strangely because there is no icon, but that is a different bug with the label placement code that I will ticket separately.

@bhousel bhousel merged commit 17c6842 into openstreetmap:master Oct 27, 2017
@bhousel bhousel mentioned this pull request Oct 27, 2017
Closed
@abdeldjalil09 abdeldjalil09 mentioned this pull request Oct 27, 2017
Closed
@bhousel bhousel mentioned this pull request Nov 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhousel bhousel bhousel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuliiaVeklycheva @bhousel