fix the raw tag editor broken and strange cursor behaviour #9766
Conversation
| @@ -32,11 +32,12 @@ export function utilGetSetValue(selection, value, shouldUpdate) { | |||
| // see https://html.spec.whatwg.org/multipage/input.html#concept-input-apply | |||
| const supportedTypes = ['text', 'search', 'url', 'tel', 'password']; | |||
| return function() { | |||
| func.apply(this, arguments); | |||
|
|
|||
| if (!supportedTypes.includes(this.type)) { | |||
| return; | |||
| } | |||
| const cursor = { start: this.selectionStart, end: this.selectionEnd }; | |||
There was a problem hiding this comment.
Based on the code that changed, these regressions were probably introduced in 14c7525 (related to #8769 and 2b64d70). I believe the intention was for this line to memoize the cursor position before setting the value in order to restore that position afterwards. It needs to go to the very top of this function before the call to apply().
k-yle
changed the title
| @@ -32,11 +32,12 @@ export function utilGetSetValue(selection, value, shouldUpdate) { | |||
| // see https://html.spec.whatwg.org/multipage/input.html#concept-input-apply | |||
| const supportedTypes = ['text', 'search', 'url', 'tel', 'password']; | |||
| return function() { | |||
| func.apply(this, arguments); | |||
|
|
|||
| if (!supportedTypes.includes(this.type)) { | |||
| return; | |||
| } | |||
| const cursor = { start: this.selectionStart, end: this.selectionEnd }; | |||
| // only certain input element types allow manipulating the cursor | ||
| // see https://html.spec.whatwg.org/multipage/input.html#concept-input-apply | ||
| const supportedTypes = ['text', 'search', 'url', 'tel', 'password']; | ||
| if (!supportedTypes.includes(this.type)) { |
There was a problem hiding this comment.
This does not quite work as probably intended: this is here the global (window) object, and not the input element we'd want to check (d3's selection.each' binds the this` variable to the DOM element in the callback function).
So, in practice, this condition is always fulfilled, even for input element types which would support cursor manipulation. As it still fixes the textarea/raw tag editor bug, I think we can keep it for the moment (even though #9233 is now an issue again), but I'll see if I can fix this a little bit better. 😊
Closes #9762, Closes #9764, Closes #9767, Closes #9773, Closes #9775, Closes #9774
to test:
edit: this PR indirectly fixes another bug reported on the OSM-US slack, where the changeset comment dropdown doesn't work