Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On enableKeepPartialLinestring, output a closed linestring if the original way is closed even on missing start/end node #133 #134

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

frodrigo
Copy link
Contributor

When using enableKeepPartialLinestring option, the output linestring should keep the closed property of the geometry, even when the location of the start/end point is missing.

Implement #133

cc @Famlam

@frodrigo frodrigo marked this pull request as draft July 16, 2023 13:29
@frodrigo frodrigo marked this pull request as ready for review July 16, 2023 13:36
frodrigo added a commit to frodrigo/osmose-backend that referenced this pull request Jul 22, 2023
…etmap/osmosis#134 osm-fr#1951

Keep closed linestring closed even if the original way is closed and missing start/end node location
frodrigo added a commit to osm-fr/osmose-backend that referenced this pull request Jul 22, 2023
…etmap/osmosis#134 #1951

Keep closed linestring closed even if the original way is closed and missing start/end node location
@brettch
Copy link
Member

brettch commented Aug 26, 2023

@frodrigo, can you please update the detailed usage docs?

@frodrigo
Copy link
Contributor Author

Doc updated.

@brettch brettch merged commit f2a3487 into openstreetmap:main Sep 2, 2023
1 check passed
@brettch
Copy link
Member

brettch commented Sep 2, 2023

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants