Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add opened editor e2e test #1863

Merged
merged 14 commits into from
Oct 31, 2022
Merged

test: add opened editor e2e test #1863

merged 14 commits into from
Oct 31, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Oct 27, 2022

Types

  • ⏱ Tests

Background or solution

追加测试:

  • 打开编辑器文件,界面正常同步文件
  • 发生分栏操作时,“打开的编辑器” 面板自动分组展示
  • 编辑器内文件发生修改,Dirty 状态在 “打开的编辑器” 面板正常展示
  • 关闭编辑器文件后,“打开的编辑器” 面板展示的文件数量减少 1 个

Changelog

add opened editor e2e test

erha19 and others added 13 commits October 27, 2022 17:23
* feat: optimize initialize performance

* chore: deps

* refactor: (wip) add lifecycle service

* refactor: (wip)

* refactor: 重构 vscode contributes 运行机制

* fix: test case

* chore: unused code

* refactor: register language logic

* chore: test case

* chore: test case

* chore: revert config

* fix: theme contribution

* chore: update comments

* chore: fix build error

Co-authored-by: Dan <danwu.wdw@alibaba-inc.com>
* chore: improve append view performance

* chore: improve append view performance
* test: implement debug breakpoint editor glyph margin test case

* test: code

* test: implement run debug test case

* fix: ci

* fix: ci

* fix: ci

* chore: fix ci

* test: implement debug breakpoint editor glyph margin test case

* fix: improve debug code

Co-authored-by: kuiwu <danwu.wdw@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 57.64% // Head: 57.63% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (481c199) compared to base (8e9c90f).
Patch coverage: 60.83% of modified lines in pull request are covered.

❗ Current head 481c199 differs from pull request most recent head 34a38fe. Consider uploading reports for the commit 34a38fe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1863      +/-   ##
==========================================
- Coverage   57.64%   57.63%   -0.02%     
==========================================
  Files        1284     1284              
  Lines       80399    80396       -3     
  Branches    16826    16826              
==========================================
- Hits        46350    46335      -15     
- Misses      30969    30980      +11     
- Partials     3080     3081       +1     
Flag Coverage Δ
jsdom 52.39% <60.67%> (-0.01%) ⬇️
node 15.89% <3.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/monaco/index.ts 100.00% <ø> (ø)
packages/debug/src/browser/debug-session.ts 10.84% <ø> (ø)
...ension/src/browser/extension-management.service.ts 47.36% <0.00%> (ø)
packages/extension/src/common/vscode/extension.ts 52.00% <ø> (ø)
...ackages/main-layout/src/browser/quick-open-view.ts 18.75% <0.00%> (ø)
packages/monaco/src/browser/contrib/tokenizer.ts 100.00% <ø> (ø)
packages/monaco/src/browser/index.ts 0.00% <ø> (ø)
packages/theme/src/browser/icon.service.ts 81.48% <ø> (ø)
...on/src/browser/vscode/contributes/views-welcome.ts 38.29% <8.33%> (ø)
.../browser/vscode/contributes/semanticTokenScopes.ts 30.00% <9.09%> (ø)
... and 116 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit b72ff66 into main Oct 31, 2022
@erha19 erha19 deleted the test/e2e/opened-editor-test branch October 31, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants