Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update watch exclude rule #1879

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

life2015
Copy link
Member

Types

update watch exclude rule

  • 🎉 New Features

Background or solution

Parcel Watcher 有一些BUG,但是Parcel Watcher本身是不支持glob的,所以只能退而求其次调整默认exclude策略,屏蔽掉node_modules目录。

Changelog

  • update watch exclude rule

@github-actions github-actions bot added the 🎨 feature feature required label Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 57.66% // Head: 57.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d27da13) compared to base (dd06f9b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   57.66%   57.66%   -0.01%     
==========================================
  Files        1284     1284              
  Lines       80403    80403              
  Branches    16826    16826              
==========================================
- Hits        46368    46361       -7     
- Misses      30958    30964       +6     
- Partials     3077     3078       +1     
Flag Coverage Δ
jsdom 52.41% <0.00%> (-0.01%) ⬇️
node 15.89% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/core-preferences.ts 92.30% <ø> (ø)
...ages/file-service/src/node/file-service-watcher.ts 77.84% <100.00%> (-2.28%) ⬇️
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.38% <0.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@life2015 life2015 force-pushed the feat/update-watch-exclude-rule branch from 24ae03a to d27da13 Compare October 31, 2022 09:41
@erha19 erha19 merged commit 9ee7419 into main Oct 31, 2022
@erha19 erha19 deleted the feat/update-watch-exclude-rule branch October 31, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants