Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support icons contribution point #1880

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Oct 31, 2022

Types

  • 🎉 New Features

Background or solution

image

Changelog

  • 支持插件注册字体图标

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 57.66% // Head: 57.64% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (20a7eb3) compared to base (dd06f9b).
Patch coverage: 47.36% of modified lines in pull request are covered.

❗ Current head 20a7eb3 differs from pull request most recent head 7e19843. Consider uploading reports for the commit 7e19843 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
- Coverage   57.66%   57.64%   -0.03%     
==========================================
  Files        1284     1284              
  Lines       80403    80458      +55     
  Branches    16826    16842      +16     
==========================================
+ Hits        46368    46381      +13     
- Misses      30958    30994      +36     
- Partials     3077     3083       +6     
Flag Coverage Δ
jsdom 52.40% <47.36%> (-0.02%) ⬇️
node 15.88% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/extension/src/browser/vscode/contributes/icon.ts 50.98% <45.94%> (-15.69%) ⬇️
.../extension/src/browser/vscode/contributes/index.ts 100.00% <100.00%> (ø)
...ages/file-service/src/node/file-service-watcher.ts 77.84% <0.00%> (-2.28%) ⬇️
...ension/src/browser/vscode/api/main.thread.tests.ts 16.32% <0.00%> (-0.53%) ⬇️
.../extension/src/hosted/api/vscode/ext.host.tests.ts 6.03% <0.00%> (-0.10%) ⬇️
packages/extension/src/common/vscode/converter.ts 39.02% <0.00%> (-0.10%) ⬇️
packages/core-browser/src/core-preferences.ts 92.30% <0.00%> (ø)
packages/core-browser/src/contextkey/testing.ts 0.00% <0.00%> (ø)
...ackages/components/src/recycle-tree/basic/types.ts 100.00% <0.00%> (ø)
...ges/extension/src/common/vscode/testing/testApi.ts 14.28% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Aaaaash Aaaaash force-pushed the feat/support-icons-contribution-point branch from 20a7eb3 to c1812df Compare November 1, 2022 02:31
@Aaaaash Aaaaash changed the title wip: support icons contribution point feat: support icons contribution point Nov 1, 2022
@Aaaaash Aaaaash force-pushed the feat/support-icons-contribution-point branch from c1812df to 7e19843 Compare November 1, 2022 02:32
@github-actions github-actions bot added the 🎨 feature feature required label Nov 1, 2022
@erha19 erha19 merged commit 213fe30 into main Nov 2, 2022
@erha19 erha19 deleted the feat/support-icons-contribution-point branch November 2, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants