Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update large file size limit #2162

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jan 5, 2023

Types

  • 🧹 Chores

Background or solution

调整 OpenSumi 内可打开的最大文件大小以及语法高亮限制。

目前 editor.languageFeatureEnabledMaxSizeeditor.docExtHostSyncMaxSize 的设计与 editor.maxTokenizationLineLength 存在一些重复性设计,目前调整至与 editor.largeFile 保持一致,后续可以考虑移除这两个配置。

Changelog

update large file size limit

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 57.79% // Head: 57.79% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (58dc3bc) compared to base (fead0d1).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
- Coverage   57.79%   57.79%   -0.01%     
==========================================
  Files        1313     1313              
  Lines       82991    82991              
  Branches    17253    17254       +1     
==========================================
- Hits        47967    47964       -3     
- Misses      31834    31836       +2     
- Partials     3190     3191       +1     
Flag Coverage Δ
jsdom 52.73% <75.00%> (-0.01%) ⬇️
node 16.52% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...owser/monaco-contrib/tokenizer/textmate.service.ts 18.71% <0.00%> (ø)
packages/editor/src/browser/preference/schema.ts 100.00% <ø> (ø)
...xtension/src/browser/vscode/api/main.thread.doc.ts 61.07% <100.00%> (ø)
...ion/src/browser/vscode/api/main.thread.language.ts 57.27% <100.00%> (ø)
packages/utils/src/buffer.ts 31.97% <0.00%> (-1.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain
Copy link
Member

bytemain commented Jan 6, 2023

我建议把这些获取数字的都重构一下,确保能获取到的是数字,比如用户给 editor.maxTokenizationLineLength 设置一个字符串,那高亮就炸了。

@bytemain
Copy link
Member

bytemain commented Jan 6, 2023

- this.preferenceService.get('editor.maxTokenizationLineLength') || 10000;
+ this.preferenceService.getValid('editor.maxTokenizationLineLength', 10000);

@erha19
Copy link
Member Author

erha19 commented Jan 9, 2023

我建议把这些获取数字的都重构一下,确保能获取到的是数字,比如用户给 editor.maxTokenizationLineLength 设置一个字符串,那高亮就炸了。

这个另外的 PR 处理吧,这里先简单改一下默认配置

@erha19 erha19 merged commit 061ff4c into main Jan 9, 2023
@erha19 erha19 deleted the chore/update-large-file-limit branch January 9, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants