Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quick open hightlight label whitespace #2265

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Feb 10, 2023

Types

  • 🐛 Bug Fixes

Background or solution

before:
image

after:
image

多 item label 节点
image

带 icon 图标时
image

带 icon 图标且搜索结果在 description 时
image

搜索 detail 内容时
image

Changelog

修复 quick open 搜索高亮时的空格消失问题

@Ricbet Ricbet requested review from hacke2 and erha19 February 10, 2023 06:00
@Ricbet Ricbet self-assigned this Feb 10, 2023
@github-actions github-actions bot added the 🐞 bug Something isn't working label Feb 10, 2023
@bytemain
Copy link
Member

我之前试了一下 这样会导致整个 item 的内容不是 wrap 了。
如果内容超长好像会超越边界。

@Ricbet
Copy link
Member Author

Ricbet commented Feb 10, 2023

我之前试了一下 这样会导致整个 item 的内容不是 wrap 了。 如果内容超长好像会超越边界。

嗯,我试试 pre-wrap

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 57.75% // Head: 57.75% // No change to project coverage 👍

Coverage data is based on head (2a6c7b0) compared to base (1397a04).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2265   +/-   ##
=======================================
  Coverage   57.75%   57.75%           
=======================================
  Files        1319     1319           
  Lines       83108    83108           
  Branches    17291    17291           
=======================================
  Hits        47999    47999           
  Misses      31910    31910           
  Partials     3199     3199           
Flag Coverage Δ
jsdom 52.70% <ø> (ø)
node 16.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet
Copy link
Member Author

Ricbet commented Feb 10, 2023

pre-wrap 不行,得 pre

@Ricbet Ricbet requested a review from bytemain February 10, 2023 07:45
@erha19 erha19 added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit 2eceb4c Feb 15, 2023
@erha19 erha19 deleted the fix/quick-open-label-space branch February 15, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants