Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support build cli-engine before release #2441

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Mar 17, 2023

Types

  • 🧹 Chores

Background or solution

CLI Engine 得走内部构建,不能只是 TSC 构建

Changelog

support build cli-engine before release

@erha19 erha19 requested a review from bk1012 March 17, 2023 06:57
@github-actions
Copy link
Contributor

ChatGPT Code Review:

CodeReview:

这次的代码变更简介是为了支持在发布前构建 cli-engine。具体来说,在三个工作流程(pr-next-release.yml、release-rc.yml 和 release.yml)中添加了 yarn run build:cli-engine 命令。

其中,在 package.json 中添加了 build:cli-engine 命令,用于编译 cli-engine;删除了 configs/ts/references/tsconfig.cli-engine.json 文件,将 cli-engine 的 tsconfig.json 配置合并到 configs/ts/tsconfig.build.json 文件中。

除此之外,还在 scripts 目录中删除了 release-cli-engine.sh 文件。

很明显,这次变更是为了在发布前构建 cli-engine,为了保证代码在使用前的稳定性和兼容性,这是一个不错的改动。

建议:

在这次的代码变更中,作者没有明显的错误或者缺陷。不过在提交代码时,建议按照 Angular 规范的 commit message 编写。比如:

feat(cli-engine): add cli-engine build step before release

这条 commit message 明确地说明了本次变更的目的和内容,有利于后续变更的记录和查找。

Copy link
Member

@bk1012 bk1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 4d256ce into main Mar 17, 2023
@erha19 erha19 deleted the chore/support-build-cli-engine-before-release branch March 17, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants