chore: optimize treeview re-render #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
看起来可以的， |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2833 +/- ##
==========================================
- Coverage 57.66% 57.62% -0.05%
==========================================
Files 1336 1337 +1
Lines 83923 84123 +200
Branches 17455 17482 +27
==========================================
+ Hits 48398 48479 +81
- Misses 32288 32394 +106
- Partials 3237 3250 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erha19
approved these changes
Jun 27, 2023
erha19
requested changes
Jul 18, 2023
erha19
approved these changes
Jul 18, 2023
Ricbet
pushed a commit
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖 Generated by Copilot at 3998ef5
Changelog
🤖 Generated by Copilot at 3998ef5
The pull request improves the performance of several components that use tree views by replacing state variables with ref variables. This avoids unnecessary re-rendering and state updates when the components are ready or loading. The affected components are
extension-tree-view,file-tree, andscm-resource-tree.