Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve secondary button hover style #2890

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jul 13, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at ec94bae

  • Improve the hover and click effects of the secondary button by adjusting the foreground and border color tokens based on the theme (link, link, link) in button.ts

解决 SecondaryButton 在部分主题下 Hover 后样式异常问题
image

Changelog

🤖 Generated by Copilot at ec94bae

This pull request enhances the secondary button component's appearance and usability by changing its color tokens. It modifies the file button.ts in the theme package to apply different shades of colors for hover and click states.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (4033de3) 57.69% compared to head (ec94bae) 57.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2890      +/-   ##
==========================================
- Coverage   57.69%   57.61%   -0.08%     
==========================================
  Files        1336     1336              
  Lines       83866    84016     +150     
  Branches    17432    17465      +33     
==========================================
+ Hits        48388    48408      +20     
- Misses      32248    32363     +115     
- Partials     3230     3245      +15     
Flag Coverage Δ
jsdom 52.65% <ø> (-0.07%) ⬇️
node 16.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/theme/src/common/color-tokens/custom/button.ts 100.00% <ø> (ø)

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 72288f5 into main Jul 17, 2023
@erha19 erha19 deleted the style/improve-secondary-button-hover-style branch July 17, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants