-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: panel use default zIndex #3170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erha19
force-pushed
the
style/fix-panel-z-index
branch
from
November 23, 2023 15:13
98e1751
to
0832ada
Compare
bytemain
requested changes
Nov 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3170 +/- ##
==========================================
- Coverage 57.69% 57.67% -0.02%
==========================================
Files 1340 1340
Lines 84533 84535 +2
Branches 17583 17583
==========================================
- Hits 48770 48759 -11
- Misses 32502 32516 +14
+ Partials 3261 3260 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bytemain
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖 Generated by Copilot at 5bd8b6c
zIndex
property from tab panel styles to fix overlap bug (link)移除无效的 zIndex 逻辑,这里会使得左右侧边栏的层级永远低于中间区域
修改后,所有视图布局均为同级,由内部组件自行控制层级
Changelog
🤖 Generated by Copilot at 5bd8b6c
Refactored the tab bar component to use React hooks and TypeScript and fixed a bug with tab panel styles. Removed the
zIndex
property from thepanelVisible
andpanelInVisible
styles inpanel.view.tsx
to prevent overlapping with other UI elements.