-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unified connection with different backend #3348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytemain
changed the title
feat: unified connection with different backend @bytemain
feat: unified connection with different backend
Feb 20, 2024
This PR is being deployed to Railway 🚅 core: ◻️ REMOVED |
erha19
requested changes
Feb 20, 2024
bytemain
force-pushed
the
feat/handler
branch
from
February 20, 2024 07:42
b1afe7f
to
f4881fa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
==========================================
+ Coverage 58.06% 58.08% +0.02%
==========================================
Files 1372 1376 +4
Lines 85764 85814 +50
Branches 17744 17753 +9
==========================================
+ Hits 49798 49845 +47
- Misses 32704 32706 +2
- Partials 3262 3263 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erha19
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
this close: #1270
previous we use wschannel to communicate with backend in Web, in electron, we create a new socket.
here we unified web and electron, all of those are using WSChannel
Changelog