Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): cancel cannot work #3382

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix(rpc): cancel cannot work #3382

merged 1 commit into from
Mar 6, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Mar 5, 2024

Types

  • 🐛 Bug Fixes

Background or solution

in #3362, we break the rpc cancel request logic, which is based on CancellationToken

here we add a test case to test cancel request.

Changelog

Fix rpc cancel request do not work

@bytemain bytemain requested review from erha19 and Ricbet March 5, 2024 13:33
Copy link

railway-app bot commented Mar 5, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.16%. Comparing base (1569088) to head (5384357).

Files Patch % Lines
packages/connection/src/common/fury-extends/any.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3382      +/-   ##
==========================================
- Coverage   58.16%   58.16%   -0.01%     
==========================================
  Files        1405     1403       -2     
  Lines       86676    86640      -36     
  Branches    17907    17903       -4     
==========================================
- Hits        50419    50391      -28     
+ Misses      32974    32966       -8     
  Partials     3283     3283              
Flag Coverage Δ
jsdom 53.01% <95.00%> (-0.02%) ⬇️
node 17.85% <95.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ricbet Ricbet merged commit 146a76c into main Mar 6, 2024
13 checks passed
@Ricbet Ricbet deleted the fix/rpc/cancel-requests branch March 6, 2024 02:26
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants