Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve diff editor first region position #3453

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Mar 26, 2024

Types

  • 🐛 Bug Fixes

Background or solution

相关 #1483

在代码折叠情况下,无需自动对齐编辑器至第一个变更区域

Changelog

improve diff editor first region position

@erha19 erha19 requested a review from Ricbet March 26, 2024 02:41
@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 26, 2024
@erha19 erha19 requested review from Aaaaash and bytemain March 26, 2024 02:42
@erha19
Copy link
Member Author

erha19 commented Mar 26, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Mar 26, 2024

🎉 PR Next publish successful!

2.27.3-next-1711421139.0

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.89%. Comparing base (3b31b77) to head (2e5376f).

Files Patch % Lines
...es/editor/src/browser/editor-collection.service.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3453      +/-   ##
==========================================
- Coverage   56.89%   56.89%   -0.01%     
==========================================
  Files        1461     1461              
  Lines       89393    89395       +2     
  Branches    18413    17393    -1020     
==========================================
  Hits        50864    50864              
- Misses      35072    38508    +3436     
+ Partials     3457       23    -3434     
Flag Coverage Δ
jsdom 52.16% <50.00%> (-0.01%) ⬇️
node 15.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 507d3b7 into main Mar 26, 2024
13 checks passed
@bytemain bytemain deleted the fix/diff-editor-position branch March 26, 2024 08:36
@erha19 erha19 added v3 OpenSumi 3.0 javascript Pull requests that update Javascript code labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working javascript Pull requests that update Javascript code v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants