Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show comfirm button when dialog buttons is undefined #3512

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 9, 2024

Types

  • 🐛 Bug Fixes

Background or solution

回调 DialogService 行为,在传入 [] buttons 数组时,不展示底部按钮,当传入 undefined 时,使用默认的确认按钮展示。

Changelog

show confirm button when dialog buttons is undefined

@erha19 erha19 requested review from bytemain and Aaaaash April 9, 2024 07:43
Copy link

railway-app bot commented Apr 9, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Apr 9, 2024
@erha19
Copy link
Member Author

erha19 commented Apr 9, 2024

/next

@erha19 erha19 changed the title fix: show comfirm button when dialog buttons is undefined WIP: fix: show comfirm button when dialog buttons is undefined Apr 9, 2024
@erha19
Copy link
Member Author

erha19 commented Apr 9, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 9, 2024

🎉 PR Next publish successful!

2.27.3-next-1712649171.0

@erha19 erha19 changed the title WIP: fix: show comfirm button when dialog buttons is undefined fix: show comfirm button when dialog buttons is undefined Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.46%. Comparing base (57c3556) to head (17e36a2).

Files Patch % Lines
packages/overlay/src/browser/dialog.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #3512     +/-   ##
=========================================
  Coverage   56.45%   56.46%             
=========================================
  Files        1480     1480             
  Lines       90300    90299      -1     
  Branches    18359    17542    -817     
=========================================
+ Hits        50979    50987      +8     
- Misses      35780    39289   +3509     
+ Partials     3541       23   -3518     
Flag Coverage Δ
jsdom 51.78% <71.42%> (+<0.01%) ⬆️
node 15.77% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 520435c into main Apr 11, 2024
11 checks passed
@erha19 erha19 deleted the fix/dialog-buttons branch April 11, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants