Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use node 18.x #3517

Merged
merged 2 commits into from
Apr 10, 2024
Merged

ci: use node 18.x #3517

merged 2 commits into from
Apr 10, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Apr 10, 2024

Types

  • ⏱ Tests

Background or solution

Changelog

Copy link

railway-app bot commented Apr 10, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@bytemain bytemain changed the title WIP: ci: use 18.x WIP: ci: use node 18.x Apr 10, 2024
@bytemain
Copy link
Member Author

应该是某个 native module 在 node 20 上跑不过

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (c648ab4) to head (ed411a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3517      +/-   ##
==========================================
- Coverage   56.84%   56.83%   -0.01%     
==========================================
  Files        1461     1461              
  Lines       89481    89481              
  Branches    18418    18213     -205     
==========================================
- Hits        50861    50854       -7     
+ Misses      38597    35158    -3439     
- Partials       23     3469    +3446     
Flag Coverage Δ
jsdom 52.10% <ø> (-0.01%) ⬇️
node 15.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain changed the title WIP: ci: use node 18.x ci: use node 18.x Apr 10, 2024
@bytemain bytemain merged commit 3f4b343 into main Apr 10, 2024
14 of 15 checks passed
@bytemain bytemain deleted the ci/fix-ci branch April 10, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants